Fix NPE in ReverseBuildTrigger due to null upstream threshold (JENKINS-39044)

Zenith1415 · Zenith1415 · commit a66a7b0d25b8 · 2025-12-07T20:48:12.000+05:30
diff --git a/core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java b/core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
@@ -166,7 +166,7 @@ private boolean shouldTrigger(Run upstreamBuild, TaskListener listener) {
             return false;
         }
         Result result = upstreamBuild.getResult();
-        return result != null && result.isBetterOrEqualTo(threshold);
+        return result != null && result.isBetterOrEqualTo(threshold != null ? threshold : Result.SUCCESS);
     }
 
     @Override public void buildDependencyGraph(final AbstractProject downstream, DependencyGraph graph) {

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ private boolean shouldTrigger(Run upstreamBuild, TaskListener listener) {`
`166`	`166`	`return false;`
`167`	`167`	`}`
`168`	`168`	`Result result = upstreamBuild.getResult();`
`169`		`- return result != null && result.isBetterOrEqualTo(threshold);`
	`169`	`+ return result != null && result.isBetterOrEqualTo(threshold != null ? threshold : Result.SUCCESS);`
`170`	`170`	`}`
`171`	`171`
`172`	`172`	`@Override public void buildDependencyGraph(final AbstractProject downstream, DependencyGraph graph) {`