Skip to content

Commit a81cab9

Browse files
authored
start introducing data-testids for test usage
The Header rework exposed numerous test failures due to changes in structure. This could have been avoided if we had already been using data-testid attributes for the various things. This starts small with the signin button. Using "login" as the testid as this is what cloudbees had already been using in our custom header and the jelly is still loginLink
1 parent 15caec2 commit a81cab9

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

core/src/main/resources/hudson/security/SecurityRealm/loginLink.jelly

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ THE SOFTWARE.
2727
<j:jelly xmlns:j="jelly:core">
2828
<a class="jenkins-button"
2929
data-type="header-action"
30+
data-testid="login"
3031
href="${rootURL}/${app.securityRealm.loginUrl}?from=${app.securityRealm.from}"
3132
style="aspect-ratio: unset; padding: 0.5rem 1rem"
3233
tooltip="${%signInTooltip}">

0 commit comments

Comments
 (0)