Allow to configure the views tab bar per user (#10379)

* allow to configure the views tab bar per user

* apply prettier

* fix spotbugs

* add license header

Author: mawinter69

core/src/main/java/hudson/model/MyViewsProperty.java

@@ -34,6 +34,7 @@
 import hudson.security.ACL;
 import hudson.util.FormValidation;
 import hudson.util.ListBoxModel;
+import hudson.views.DefaultViewsTabBar;
 import hudson.views.MyViewsTabBar;
 import hudson.views.ViewsTabBar;
 import jakarta.servlet.ServletException;
@@ -81,6 +82,8 @@ public class MyViewsProperty extends UserProperty implements ModifiableViewGroup
     @CheckForNull
     private String primaryViewName;
 
+    private ViewsTabBar viewsTabBar = new DefaultViewsTabBar();
+
     /**
      * Always hold at least one view.
      */
@@ -124,6 +127,9 @@ public Object readResolve() {
             protected void primaryView(String name) { primaryViewName = name; }
         };
 
+        if (viewsTabBar == null) {
+            viewsTabBar = new DefaultViewsTabBar();
+        }
         return this;
     }
 
@@ -284,6 +290,7 @@ public ListBoxModel doFillPrimaryViewNameItems(@AncestorInPath User user) throws
                 MyViewsProperty property = user.getProperty(MyViewsProperty.class);
                 if (property == null) {
                     property = new MyViewsProperty();
+                    property.readResolve();
                     user.addProperty(property);
                 }
                 for (View view : property.views) {
@@ -303,7 +310,11 @@ public UserProperty reconfigure(StaplerRequest2 req, JSONObject form) throws For
 
     @Override
     public ViewsTabBar getViewsTabBar() {
-        return Jenkins.get().getViewsTabBar();
+        return viewsTabBar;
+    }
+
+    public void setViewsTabBar(ViewsTabBar viewsTabBar) {
+        this.viewsTabBar = viewsTabBar;
     }
 
     @Override

core/src/main/java/hudson/model/ViewGroup.java

@@ -33,6 +33,7 @@
 import java.util.LinkedHashSet;
 import java.util.List;
 import jenkins.model.Jenkins;
+import jenkins.views.ViewsTabBarUserProperty;
 
 /**
  * Container of {@link View}s.
@@ -159,4 +160,23 @@ default List<Action> getViewActions() {
         return Jenkins.get().getActions();
     }
 
+    /**
+     * Returns the ViewsTabBar that the user has configured.
+     *
+     * @return users TabBar
+     * @since TODO
+     */
+    default ViewsTabBar getUserViewsTabBar() {
+        User user = User.current();
+        if (user != null) {
+            ViewsTabBarUserProperty viewsTabBarUserProperty = user.getProperty(ViewsTabBarUserProperty.class);
+            if (viewsTabBarUserProperty != null) {
+                ViewsTabBar userViewTabsBars = viewsTabBarUserProperty.getViewsTabBar();
+                if (userViewTabsBars != null) {
+                    return userViewTabsBars;
+                }
+            }
+        }
+        return getViewsTabBar();
+    }
 }

core/src/main/java/hudson/views/DefaultMyViewsTabBar.java

@@ -35,7 +35,9 @@
  * @author Winston Prakash
  * @since 1.378
  * @see MyViewsTabBar
+ * @deprecated No longer used
  */
+@Deprecated
 public class DefaultMyViewsTabBar extends MyViewsTabBar {
     @DataBoundConstructor
     public DefaultMyViewsTabBar() {

core/src/main/java/hudson/views/MyViewsTabBar.java

@@ -58,7 +58,9 @@
  * @author Winston Prakash
  * @since 1.378
  * @see MyViewsTabBarDescriptor
+ * @deprecated Implement {@link ViewsTabBar}
  */
+@Deprecated
 public abstract class MyViewsTabBar implements Describable<MyViewsTabBar>, ExtensionPoint {
     /**
      * Returns all the registered {@link ListViewColumn} descriptors.

core/src/main/java/jenkins/model/Jenkins.java

@@ -1941,10 +1941,12 @@ public Jenkins getItemGroup() {
         return this;
    }
 
+    @Deprecated
     public MyViewsTabBar getMyViewsTabBar() {
         return myViewsTabBar;
     }
 
+    @Deprecated
     public void setMyViewsTabBar(MyViewsTabBar myViewsTabBar) {
         this.myViewsTabBar = myViewsTabBar;
     }

core/src/main/java/jenkins/views/ViewsTabBarUserProperty.java

@@ -0,0 +1,80 @@
+/*
+ * The MIT License
+ *
+ * Copyright (c) 2025 Markus Winter
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+package jenkins.views;
+
+import edu.umd.cs.findbugs.annotations.CheckForNull;
+import edu.umd.cs.findbugs.annotations.NonNull;
+import hudson.Extension;
+import hudson.model.User;
+import hudson.model.UserProperty;
+import hudson.model.UserPropertyDescriptor;
+import hudson.model.userproperty.UserPropertyCategory;
+import hudson.views.ViewsTabBar;
+import org.jenkinsci.Symbol;
+import org.kohsuke.accmod.Restricted;
+import org.kohsuke.accmod.restrictions.NoExternalUse;
+import org.kohsuke.stapler.DataBoundConstructor;
+import org.kohsuke.stapler.DataBoundSetter;
+
+@Restricted(NoExternalUse.class)
+public class ViewsTabBarUserProperty extends UserProperty {
+
+    private ViewsTabBar viewsTabBar;
+
+    @DataBoundConstructor
+    public ViewsTabBarUserProperty() {
+    }
+
+    @DataBoundSetter
+    public void setViewsTabBar(ViewsTabBar viewsTabBar) {
+        this.viewsTabBar = viewsTabBar;
+    }
+
+    @CheckForNull
+    public ViewsTabBar getViewsTabBar() {
+        return viewsTabBar;
+    }
+
+    @Extension
+    @Symbol("viewsTabBar")
+    public static class DescriptorImpl extends UserPropertyDescriptor {
+
+        @NonNull
+        @Override
+        public String getDisplayName() {
+            return Messages.ViewsTabBarUserProperty_DisplayName();
+        }
+
+        @Override
+        public UserProperty newInstance(User user) {
+            return new ViewsTabBarUserProperty();
+        }
+
+        @Override
+        public @NonNull UserPropertyCategory getUserPropertyCategory() {
+            return UserPropertyCategory.get(UserPropertyCategory.Preferences.class);
+        }
+    }
+}

core/src/main/resources/hudson/model/MyViewsProperty/config.jelly

@@ -28,4 +28,8 @@ THE SOFTWARE.
     description="${%description}">
     <f:select field="primaryViewName"/>
   </f:entry>
+  <j:invokeStatic var="allViewsTabBar" className="hudson.views.ViewsTabBar" method="all"/>
+  <j:if test="${allViewsTabBar.size() > 1}">
+    <f:dropdownDescriptorSelector field="viewsTabBar" title="${%Views Tab Bar}"/>
+  </j:if>
 </j:jelly>

core/src/main/resources/hudson/model/MyViewsProperty/help-viewsTabBar.html

@@ -0,0 +1,5 @@
+<div>
+  The Views Tab Bar to use on
+  <em>My Views</em>
+  .
+</div>

core/src/main/resources/hudson/model/View/main.groovy

@@ -1,5 +1,7 @@
 package hudson.model.View
 
+import hudson.model.MyViewsProperty
+
 t=namespace(lib.JenkinsTagLib)
 st=namespace("jelly:stapler")
 
@@ -9,17 +11,21 @@ if (items == null) {
     if (app.items.size() != 0) {
         set("views",my.owner.views)
         set("currentView",my)
-        include(my.owner.viewsTabBar, "viewTabs")
+        if (my.owner.class == MyViewsProperty.class) {
+            include(my.owner?.viewsTabBar, "viewTabs")
+        } else {
+            include(my.owner.userViewsTabBar, "viewTabs")
+        }
     }
     include(my,"noJob.jelly")
 } else {
     t.projectView(jobs: items, showViewTabs: true, columnExtensions: my.columns, indenter: my.indenter, itemGroup: my.owner.itemGroup) {
         set("views",my.owner.views)
         set("currentView",my)
-        if (my.owner.class == hudson.model.MyViewsProperty.class) {
-            include(my.owner?.myViewsTabBar, "myViewTabs")
+        if (my.owner.class == MyViewsProperty.class) {
+            include(my.owner?.viewsTabBar, "viewTabs")
         } else {
-            include(my.owner.viewsTabBar,"viewTabs")
+            include(my.owner.userViewsTabBar,"viewTabs")
         }
     }
 }