[JENKINS-75465] (Recreate) Delete RunIdMigrator as it has been 10 years since this migration (#10521)

Author: gbhat618

core/src/main/java/hudson/model/Job.java

@@ -97,7 +97,6 @@
 import jenkins.model.ModelObjectWithChildren;
 import jenkins.model.PeepholePermalink;
 import jenkins.model.ProjectNamingStrategy;
-import jenkins.model.RunIdMigrator;
 import jenkins.model.lazy.LazyBuildMixIn;
 import jenkins.scm.RunWithSCM;
 import jenkins.security.HexStringConfidentialKey;
@@ -192,10 +191,6 @@ public abstract class Job<JobT extends Job<JobT, RunT>, RunT extends Run<JobT, R
     // this should have been DescribableList but now it's too late
     protected CopyOnWriteList<JobProperty<? super JobT>> properties = new CopyOnWriteList<>();
 
-    @Restricted(NoExternalUse.class)
-    @SuppressFBWarnings(value = "PA_PUBLIC_PRIMITIVE_ATTRIBUTE", justification = "Preserve API compatibility")
-    public transient RunIdMigrator runIdMigrator;
-
     protected Job(ItemGroup parent, String name) {
         super(parent, name);
     }
@@ -206,20 +201,19 @@ public synchronized void save() throws IOException {
         holdOffBuildUntilSave = holdOffBuildUntilUserSave;
     }
 
-    @Override public void onCreatedFromScratch() {
-        super.onCreatedFromScratch();
-        runIdMigrator = new RunIdMigrator();
-        runIdMigrator.created(getBuildDir());
-    }
-
     @Override
     public void onLoad(ItemGroup<? extends Item> parent, String name)
             throws IOException {
         super.onLoad(parent, name);
 
-        File buildDir = getBuildDir();
-        runIdMigrator = new RunIdMigrator();
-        runIdMigrator.migrate(buildDir, Jenkins.get().getRootDir());
+        // see https://github.com/jenkinsci/jenkins/pull/10456#issuecomment-2748112449
+        // This code can be deleted after several Jenkins releases,
+        // when it is likely that everyone is running a version equal or higher to this version.
+        var buildDirPath = getBuildDir().toPath();
+        if (Files.deleteIfExists(buildDirPath.resolve("legacyIds"))) {
+            LOGGER.info("Deleting legacyIds file in " + buildDirPath + ". See https://issues.jenkins"
+                        + ".io/browse/JENKINS-75465 for more information.");
+        }
 
         TextFile f = getNextBuildNumberFile();
         if (f.exists()) {

core/src/main/java/hudson/model/RunMap.java

@@ -45,10 +45,8 @@
 import java.util.SortedMap;
 import java.util.logging.Level;
 import java.util.logging.Logger;
-import jenkins.model.RunIdMigrator;
 import jenkins.model.lazy.AbstractLazyLoadRunMap;
 import jenkins.model.lazy.BuildReference;
-import jenkins.model.lazy.LazyBuildMixIn;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.NoExternalUse;
 
@@ -72,10 +70,6 @@ public final class RunMap<R extends Run<?, R>> extends AbstractLazyLoadRunMap<R>
 
     private Constructor<R> cons;
 
-    /** Normally overwritten by {@link LazyBuildMixIn#onLoad} or {@link LazyBuildMixIn#onCreatedFromScratch}, in turn created during {@link Job#onLoad}. */
-    @Restricted(NoExternalUse.class)
-    public RunIdMigrator runIdMigrator = new RunIdMigrator();
-
     // TODO: before first complete build
     // patch up next/previous build link
 
@@ -156,7 +150,6 @@ public void remove() {
     @Override
     public boolean removeValue(R run) {
         run.dropLinks();
-        runIdMigrator.delete(dir, run.getId());
         return super.removeValue(run);
     }
 
@@ -227,14 +220,13 @@ public R put(R r) {
         return super._put(r);
     }
 
+    @CheckForNull
     @Override public R getById(String id) {
-        int n;
         try {
-            n = Integer.parseInt(id);
-        } catch (NumberFormatException x) {
-            n = runIdMigrator.findNumber(id);
+            return getByNumber(Integer.parseInt(id));
+        } catch (NumberFormatException e) { // see https://issues.jenkins.io/browse/JENKINS-75476
+            return null;
         }
-        return getByNumber(n);
     }
 
     /**

core/src/main/java/jenkins/model/RunIdMigrator.java

@@ -49,7 +49,6 @@
 import java.util.Objects;
 import java.util.logging.Level;
 import java.util.logging.Logger;
-import jenkins.model.RunIdMigrator;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.DoNotUse;
 
@@ -147,9 +146,6 @@ public RunT create(File dir) throws IOException {
                 return loadBuild(dir);
             }
         });
-        RunIdMigrator runIdMigrator = asJob().runIdMigrator;
-        assert runIdMigrator != null;
-        r.runIdMigrator = runIdMigrator;
         return r;
     }