Add separator between items and 'Duplicate an item'

Author: janfaracik

core/src/main/resources/hudson/model/View/newJob.jelly

@@ -52,12 +52,10 @@ THE SOFTWARE.
             <fieldset class="jenkins-!-display-contents">
               <div class="jenkins-form-item">
                 <legend class="jenkins-form-label">${%ItemType.label}</legend>
-                <div id="items" class="jenkins-choice-list categories" data-valid="false">
-                  <template id="insertion-point">
-                    <!-- Job types need to be added above this point -->
-                  </template>
+                <div id="items" class="jenkins-choice-list categories" data-valid="false" />
 
-                  <j:if test="${!empty(app.items)}">
+                <j:if test="${!empty(app.items)}">
+                  <div class="jenkins-choice-list jenkins-!-margin-top-2">
                     <div class="jenkins-choice-list__item">
                       <label id="duplicate-job">
                         <div class="jenkins-choice-list__item__icon">
@@ -75,8 +73,8 @@ THE SOFTWARE.
                         <s:textbox id="from" data-valid="false" name="from" placeholder="${%CopyOption.placeholder}" field="copyNewItemFrom"/>
                       </div>
                     </div>
-                  </j:if>
-                </div>
+                  </div>
+                </j:if>
               </div>
             </fieldset>
 

src/main/js/add-item.js

@@ -232,9 +232,9 @@ document.addEventListener("DOMContentLoaded", () => {
     document.querySelector("#add-item-panel").removeAttribute("style");
 
     // Render all categories
-    var $categories = document.querySelector(".categories template");
+    var $categories = document.querySelector(".categories");
     data.categories.forEach((elem) => {
-      drawCategory(elem).forEach((e) => $categories.before(e));
+      drawCategory(elem).forEach((e) => $categories.append(e));
     });
 
     // Init NameField