Fix synchronization, PluginWrapper bug, and cleanup Javadoc

- Fix inconsistent synchronization in Fingerprint.java on 'usages' field by synchronizing on 'this'.
- Fix logic bug in PluginWrapper.java where setOptionalDependants passed incorrect field instead of parameter.
- Replace Boolean.getBoolean with SystemProperties.getBoolean in Jenkins.java and JnlpSlaveRestarterInstaller.java for best practices.
- Update placeholder version numbers (@deprecated and @SInCE) in StreamTaskListener, StreamBuildListener, and JNLPLauncher.

Signed-off-by: shbhmexe <shubhushukla586@gmail.com>

Author: shbhmexe

core/src/main/java/hudson/PluginWrapper.java

@@ -253,7 +253,7 @@ public void setOptionalDependents(@NonNull Set<String> optionalDependents) {
      */
     @Deprecated
     public void setOptionalDependants(@NonNull Set<String> optionalDependents) {
-        setOptionalDependents(dependents);
+        setOptionalDependents(optionalDependents);
     }
 
     /**

core/src/main/java/hudson/model/Fingerprint.java

@@ -1036,7 +1036,7 @@ protected Object readResolve() {
     }
 
     void addWithoutSaving(@NonNull String jobFullName, int n) {
-        synchronized (usages) { // TODO why not synchronized (this) like some, though not all, other accesses?
+        synchronized (this) {
             RangeSet r = usages.get(jobFullName);
             if (r == null) {
                 r = new RangeSet();

core/src/main/java/hudson/model/StreamBuildListener.java

@@ -48,7 +48,7 @@ public StreamBuildListener(File out, Charset charset) throws IOException {
     }
 
     /**
-     * @deprecated as of TODO
+     * @deprecated as of 2.328
      *      The caller should use {@link #StreamBuildListener(OutputStream, Charset)} to pass in
      *      the charset and output stream separately, so that this class can handle encoding correctly.
      */

core/src/main/java/hudson/slaves/JNLPLauncher.java

@@ -185,7 +185,7 @@ public void launch(SlaveComputer computer, TaskListener listener) {
     }
 
     /**
-     * @deprecated as of 1.XXX
+     * @deprecated as of 2.0
      *      Use {@link Jenkins#getDescriptor(Class)}
      */
     @Deprecated

core/src/main/java/hudson/util/StreamTaskListener.java

@@ -74,7 +74,7 @@ public StreamTaskListener(@NonNull PrintStream out) {
     }
 
     /**
-     * @deprecated as of TODO
+     * @deprecated as of 2.328
      *      The caller should use {@link #StreamTaskListener(OutputStream, Charset)} to pass in
      *      the charset and output stream separately, so that this class can handle encoding correctly,
      *      or use {@link #fromStdout()} or {@link #fromStderr()}.
@@ -94,7 +94,7 @@ public StreamTaskListener(@NonNull OutputStream out, @CheckForNull Charset chars
     }
 
     /**
-     * @deprecated as of TODO
+     * @deprecated as of 2.328
      *      The caller should use {@link #StreamTaskListener(File, Charset)} to pass in
      *      the charset and file separately, so that this class can handle encoding correctly.
      */

core/src/main/java/jenkins/model/Jenkins.java

@@ -5726,7 +5726,7 @@ private static void computeVersion(ServletContext context) {
     @Restricted(NoExternalUse.class)
     public boolean shouldShowStackTrace() {
         // Used by oops.jelly
-        return Boolean.getBoolean(Jenkins.class.getName() + ".SHOW_STACK_TRACE");
+        return SystemProperties.getBoolean(Jenkins.class.getName() + ".SHOW_STACK_TRACE");
     }
 
     /**

core/src/main/java/jenkins/slaves/restarter/JnlpSlaveRestarterInstaller.java

@@ -21,6 +21,7 @@
 import java.util.concurrent.Callable;
 import java.util.logging.Logger;
 import jenkins.security.MasterToSlaveCallable;
+import jenkins.util.SystemProperties;
 
 /**
  * Actual agent restart logic.
@@ -36,7 +37,7 @@ public class JnlpSlaveRestarterInstaller extends ComputerListener implements Ser
     /**
      * To force installer to run on all agents, set this system property to true.
      */
-    private static final boolean FORCE_INSTALL = Boolean.getBoolean(JnlpSlaveRestarterInstaller.class.getName() + ".forceInstall");
+    private static final boolean FORCE_INSTALL = SystemProperties.getBoolean(JnlpSlaveRestarterInstaller.class.getName() + ".forceInstall");
 
     @SuppressFBWarnings(value = "RV_RETURN_VALUE_IGNORED_BAD_PRACTICE", justification = "method signature does not permit plumbing through the return value")
     @Override