Skip to content

Commit e11db85

Browse files
author
Vincent Potucek
committed
Add rewrite support for staticanalysis.RemoveUnusedPrivateMethods
1 parent 79f9ebd commit e11db85

File tree

2 files changed

+58
-3
lines changed

2 files changed

+58
-3
lines changed

pom.xml

Lines changed: 44 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -286,11 +286,10 @@ THE SOFTWARE.
286286
</dependencies>
287287
<executions>
288288
<execution>
289-
<id>validate</id>
290289
<goals>
291290
<goal>check</goal>
292291
</goals>
293-
<phase>validate</phase>
292+
<phase>verify</phase>
294293
</execution>
295294
</executions>
296295
</plugin>
@@ -299,10 +298,52 @@ THE SOFTWARE.
299298
<artifactId>jacoco-maven-plugin</artifactId>
300299
<version>0.8.13</version>
301300
</plugin>
301+
<plugin>
302+
<groupId>org.openrewrite.maven</groupId>
303+
<artifactId>rewrite-maven-plugin</artifactId>
304+
<version>6.15.0</version>
305+
<configuration>
306+
<activeRecipes>
307+
<recipe>org.jenkins.openrewrite.DefinitionOfDone</recipe>
308+
</activeRecipes>
309+
<exclusions>
310+
<exclusion>**ApiTokenStats.java</exclusion>
311+
<exclusion>**DownloadFromUrlInstaller.java</exclusion>
312+
<exclusion>**generated-test-sources**</exclusion>
313+
</exclusions>
314+
<exportDatatables>true</exportDatatables>
315+
<failOnDryRunResults>true</failOnDryRunResults>
316+
</configuration>
317+
<dependencies>
318+
<dependency>
319+
<groupId>org.openrewrite.recipe</groupId>
320+
<artifactId>rewrite-static-analysis</artifactId>
321+
<version>2.15.0</version>
322+
</dependency>
323+
<dependency>
324+
<groupId>org.openrewrite.recipe</groupId>
325+
<artifactId>rewrite-third-party</artifactId>
326+
<version>0.24.3</version>
327+
</dependency>
328+
</dependencies>
329+
<executions>
330+
<!--move to CI-->
331+
<execution>
332+
<goals>
333+
<goal>dryRun</goal>
334+
</goals>
335+
<phase>verify</phase>
336+
</execution>
337+
</executions>
338+
</plugin>
302339
</plugins>
303340
</pluginManagement>
304341

305342
<plugins>
343+
<plugin>
344+
<groupId>org.openrewrite.maven</groupId>
345+
<artifactId>rewrite-maven-plugin</artifactId>
346+
</plugin>
306347
<plugin>
307348
<groupId>com.diffplug.spotless</groupId>
308349
<artifactId>spotless-maven-plugin</artifactId>
@@ -328,7 +369,7 @@ THE SOFTWARE.
328369
<configuration>
329370
<!-- work around for a bug in javadoc plugin that causes the release to fail. see MRELEASE-271 -->
330371
<preparationGoals>clean install</preparationGoals>
331-
<goals>-DskipTests -Dspotbugs.skip -Dmaven.checkstyle.skip -Dspotless.check.skip generate-resources javadoc:javadoc deploy</goals>
372+
<goals>-DskipTests -Dspotbugs.skip -Dmaven.checkstyle.skip -Dspotless.check.skip -DrewriteSkip generate-resources javadoc:javadoc deploy</goals>
332373
<pushChanges>false</pushChanges>
333374
<localCheckout>true</localCheckout>
334375
<tagNameFormat>jenkins-@{project.version}</tagNameFormat>

rewrite.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
type: specs.openrewrite.org/v1beta/recipe
2+
name: org.jenkins.openrewrite.DefinitionOfDone
3+
displayName: Definition of Done
4+
description: Automatically code cleanup to comply common convention.
5+
recipeList:
6+
- org.openrewrite.staticanalysis.ModifierOrder
7+
# - org.openrewrite.java.RemoveUnusedImports
8+
# - org.openrewrite.staticanalysis.LowercasePackage
9+
# - org.openrewrite.staticanalysis.MissingOverrideAnnotation
10+
# - org.openrewrite.staticanalysis.RemoveUnusedLocalVariables
11+
# - org.openrewrite.staticanalysis.RemoveUnusedPrivateFields
12+
# - org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods
13+
# - tech.picnic.errorprone.refasterrules.BugCheckerRulesRecipes
14+
# - tech.picnic.errorprone.refasterrules.FileRulesRecipes # security fixes

0 commit comments

Comments
 (0)