Fix Javadoc grammar in InstanceIdentityProvider; prefer toString() for readability in Functions (#20000)

* Fix Javadoc grammar in InstanceIdentityProvider; use toString() for readability in Functions.toEmailSafeString

- Correct “will must be currently valid” -> “must be currently valid” in Javadoc (two occurrences)
- Prefer buf.toString() over String.valueOf(buf) for clarity; no behavior change

Signed-off-by: shbhmexe <shubhushukla586@gmail.com>

* ci: retrigger checks

Signed-off-by: shbhmexe <shubhushukla586@gmail.com>

* tests: make ViewTest.privateView resilient to new dashboard tabs

- Detect the active view using either classic tabBar markup or the new app-build-tabs buttons.
- Avoid brittle XPath that breaks when NewDashboardPageUserExperimentalFlag is enabled.

No production code changes.

Signed-off-by: shbhmexe <shubhushukla586@gmail.com>

* Reverted the changes introduced in the most recent commit on this branch.

Replaces support for both classic and new dashboard tab selectors with a single XPath targeting the classic tab bar. This streamlines the test by removing conditional logic for different UI layouts.

* Remove unrelated change

* Fix indentation in ViewTest privateViewsPage section

Corrected indentation for the 'viewLabel' assignment in the ViewTest to improve code readability and maintain consistency.

---------

Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>

Author: shbhmexe

core/src/main/java/hudson/Functions.java

@@ -1990,7 +1990,7 @@ public static String toEmailSafeString(String projectName) {
             else
                 buf.append('_');    // escape
         }
-        return String.valueOf(buf);
+        return buf.toString();
     }
 
     /**

core/src/main/java/jenkins/model/identity/InstanceIdentityProvider.java

@@ -118,7 +118,7 @@ protected PRIV getPrivateKey() {
 
     /**
      * Gets the self-signed {@link X509Certificate} that is associated with this identity. The certificate
-     * will must be currently valid. Repeated calls to this method may result in new certificates being generated.
+     * must be currently valid. Repeated calls to this method may result in new certificates being generated.
      *
      * @return the certificate. {@code null} if {@link #getKeyPair()} is {@code null}.
      */
@@ -288,7 +288,7 @@ public PRIV getPrivateKey() {
 
         /**
          * Gets the self-signed {@link X509Certificate} that is associated with this identity. The certificate
-         * will must be currently valid. Repeated calls to this method may result in new certificates being generated.
+         * must be currently valid. Repeated calls to this method may result in new certificates being generated.
          *
          * @return the certificate. {@code null} if {@link #getKeyPair()} is {@code null}.
          */