Skip to content

Commit e9a39c7

Browse files
committed
Merge branch 'master' of https://github.com/jenkinsci/jenkins into AdministrativeMonitorsDecorator
2 parents adbc68d + 2a27e84 commit e9a39c7

File tree

9 files changed

+28
-86
lines changed

9 files changed

+28
-86
lines changed

bom/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ THE SOFTWARE.
7171
<!-- https://docs.spring.io/spring-security/reference/6.3/getting-spring-security.html#getting-maven-no-boot -->
7272
<groupId>org.springframework.security</groupId>
7373
<artifactId>spring-security-bom</artifactId>
74-
<version>6.5.1</version>
74+
<version>6.5.2</version>
7575
<type>pom</type>
7676
<scope>import</scope>
7777
</dependency>
@@ -119,7 +119,7 @@ THE SOFTWARE.
119119
<dependency>
120120
<groupId>commons-io</groupId>
121121
<artifactId>commons-io</artifactId>
122-
<version>2.19.0</version>
122+
<version>2.20.0</version>
123123
</dependency>
124124
<dependency>
125125
<groupId>commons-lang</groupId>

core/src/main/java/hudson/Functions.java

Lines changed: 8 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
import hudson.model.Describable;
4242
import hudson.model.Descriptor;
4343
import hudson.model.DescriptorVisibilityFilter;
44-
import hudson.model.Hudson;
4544
import hudson.model.Item;
4645
import hudson.model.ItemGroup;
4746
import hudson.model.Items;
@@ -97,11 +96,9 @@
9796
import hudson.views.MyViewsTabBar;
9897
import hudson.views.ViewsTabBar;
9998
import hudson.widgets.RenderOnDemandClosure;
100-
import io.jenkins.servlet.ServletExceptionWrapper;
10199
import io.jenkins.servlet.http.CookieWrapper;
102100
import io.jenkins.servlet.http.HttpServletRequestWrapper;
103101
import io.jenkins.servlet.http.HttpServletResponseWrapper;
104-
import jakarta.servlet.ServletException;
105102
import jakarta.servlet.http.Cookie;
106103
import jakarta.servlet.http.HttpServletRequest;
107104
import jakarta.servlet.http.HttpServletResponse;
@@ -190,8 +187,6 @@
190187
import org.kohsuke.stapler.Stapler;
191188
import org.kohsuke.stapler.StaplerRequest;
192189
import org.kohsuke.stapler.StaplerRequest2;
193-
import org.kohsuke.stapler.StaplerResponse;
194-
import org.kohsuke.stapler.StaplerResponse2;
195190
import org.springframework.security.access.AccessDeniedException;
196191

197192
/**
@@ -921,11 +916,11 @@ public static String htmlAttributeEscape(String text) {
921916
return buf.toString();
922917
}
923918

924-
public static void checkPermission(Permission permission) throws IOException, ServletException {
919+
public static void checkPermission(Permission permission) {
925920
checkPermission(Jenkins.get(), permission);
926921
}
927922

928-
public static void checkPermission(AccessControlled object, Permission permission) throws IOException, ServletException {
923+
public static void checkPermission(AccessControlled object, Permission permission) {
929924
if (permission != null) {
930925
object.checkPermission(permission);
931926
}
@@ -936,7 +931,7 @@ public static void checkPermission(AccessControlled object, Permission permissio
936931
* degrades gracefully if "it" is not an {@link AccessControlled} object.
937932
* Otherwise it will perform no check and that problem is hard to notice.
938933
*/
939-
public static void checkPermission(Object object, Permission permission) throws IOException, ServletException {
934+
public static void checkPermission(Object object, Permission permission) {
940935
if (permission == null)
941936
return;
942937

@@ -961,15 +956,15 @@ public static void checkPermission(Object object, Permission permission) throws
961956
* @param permission
962957
* If null, returns true. This defaulting is convenient in making the use of this method terse.
963958
*/
964-
public static boolean hasPermission(Permission permission) throws IOException, ServletException {
959+
public static boolean hasPermission(Permission permission) {
965960
return hasPermission(Jenkins.get(), permission);
966961
}
967962

968963
/**
969964
* This version is so that the 'hasPermission' can degrade gracefully
970965
* if "it" is not an {@link AccessControlled} object.
971966
*/
972-
public static boolean hasPermission(Object object, Permission permission) throws IOException, ServletException {
967+
public static boolean hasPermission(Object object, Permission permission) {
973968
if (permission == null)
974969
return true;
975970
if (object instanceof AccessControlled)
@@ -986,36 +981,6 @@ public static boolean hasPermission(Object object, Permission permission) throws
986981
}
987982
}
988983

989-
/**
990-
* @since 2.475
991-
*/
992-
public static void adminCheck(StaplerRequest2 req, StaplerResponse2 rsp, Object required, Permission permission) throws IOException, ServletException {
993-
// this is legacy --- all views should be eventually converted to
994-
// the permission based model.
995-
if (required != null && !Hudson.adminCheck(StaplerRequest.fromStaplerRequest2(req), StaplerResponse.fromStaplerResponse2(rsp))) {
996-
// check failed. commit the FORBIDDEN response, then abort.
997-
rsp.setStatus(HttpServletResponse.SC_FORBIDDEN);
998-
rsp.getOutputStream().close();
999-
throw new ServletException("Unauthorized access");
1000-
}
1001-
1002-
// make sure the user owns the necessary permission to access this page.
1003-
if (permission != null)
1004-
checkPermission(permission);
1005-
}
1006-
1007-
/**
1008-
* @deprecated use {@link #adminCheck(StaplerRequest2, StaplerResponse2, Object, Permission)}
1009-
*/
1010-
@Deprecated
1011-
public static void adminCheck(StaplerRequest req, StaplerResponse rsp, Object required, Permission permission) throws IOException, javax.servlet.ServletException {
1012-
try {
1013-
adminCheck(StaplerRequest.toStaplerRequest2(req), StaplerResponse.toStaplerResponse2(rsp), required, permission);
1014-
} catch (ServletException e) {
1015-
throw ServletExceptionWrapper.fromJakartaServletException(e);
1016-
}
1017-
}
1018-
1019984
/**
1020985
* Infers the hudson installation URL from the given request.
1021986
*
@@ -1298,7 +1263,7 @@ public static boolean hasAnyPermission(AccessControlled ac, Permission[] permiss
12981263
*
12991264
* @since 2.238
13001265
*/
1301-
public static boolean hasAnyPermission(Object object, Permission[] permissions) throws IOException, ServletException {
1266+
public static boolean hasAnyPermission(Object object, Permission[] permissions) {
13021267
if (permissions == null || permissions.length == 0) {
13031268
return true;
13041269
}
@@ -1336,7 +1301,7 @@ public static void checkAnyPermission(AccessControlled ac, Permission[] permissi
13361301
* degrades gracefully if "it" is not an {@link AccessControlled} object.
13371302
* Otherwise it will perform no check and that problem is hard to notice.
13381303
*/
1339-
public static void checkAnyPermission(Object object, Permission[] permissions) throws IOException, ServletException {
1304+
public static void checkAnyPermission(Object object, Permission[] permissions) {
13401305
if (permissions == null || permissions.length == 0) {
13411306
return;
13421307
}
@@ -2099,7 +2064,7 @@ public boolean hyperlinkMatchesCurrentPage(String href) {
20992064
}
21002065

21012066
/**
2102-
* If the given {@code Action} is a {@link RootAction#isPrimaryAction() primary} {code RootAction}, or a parent of the current page, return {@code true}.
2067+
* If the given {@code Action} is a {@link RootAction#isPrimaryAction() primary} {@code RootAction}, or a parent of the current page, return {@code true}.
21032068
* Used in {@code actions.jelly} to decide if the action should shown in the main header or the hamburger.
21042069
*/
21052070
@Restricted(NoExternalUse.class)

core/src/main/java/hudson/model/Hudson.java

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
import io.jenkins.servlet.ServletExceptionWrapper;
4343
import jakarta.servlet.ServletContext;
4444
import jakarta.servlet.ServletException;
45-
import jakarta.servlet.http.HttpServletResponse;
4645
import java.io.File;
4746
import java.io.IOException;
4847
import java.text.NumberFormat;
@@ -51,7 +50,6 @@
5150
import jenkins.model.Jenkins;
5251
import org.jvnet.hudson.reactor.ReactorException;
5352
import org.kohsuke.stapler.QueryParameter;
54-
import org.kohsuke.stapler.Stapler;
5553
import org.kohsuke.stapler.StaplerRequest;
5654
import org.kohsuke.stapler.StaplerResponse;
5755
import org.kohsuke.stapler.interceptor.RequirePOST;
@@ -293,27 +291,6 @@ public static boolean isDarwin() {
293291
return Platform.isDarwin();
294292
}
295293

296-
/**
297-
* @deprecated since 2007-12-18.
298-
* Use {@link #checkPermission(hudson.security.Permission)}
299-
*/
300-
@Deprecated
301-
public static boolean adminCheck() throws IOException {
302-
return adminCheck(Stapler.getCurrentRequest(), Stapler.getCurrentResponse());
303-
}
304-
305-
/**
306-
* @deprecated since 2007-12-18.
307-
* Use {@link #checkPermission(hudson.security.Permission)}
308-
*/
309-
@Deprecated
310-
public static boolean adminCheck(StaplerRequest req, StaplerResponse rsp) throws IOException {
311-
if (isAdmin(req)) return true;
312-
313-
rsp.sendError(HttpServletResponse.SC_FORBIDDEN);
314-
return false;
315-
}
316-
317294
/**
318295
* Checks if the current user (for which we are processing the current request)
319296
* has the admin access.

core/src/main/java/jenkins/model/Jenkins.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2836,7 +2836,7 @@ public <T> ExtensionList<T> getExtensionList(Class<T> extensionType) {
28362836
* For URL access to descriptors, see {@link hudson.model.DescriptorByNameOwner}.
28372837
* For URL access to specific other {@link hudson.Extension} annotated elements, create your own {@link hudson.model.Action}, like {@link hudson.console.ConsoleAnnotatorFactory.RootAction}.
28382838
*/
2839-
@Deprecated(since = "TODO")
2839+
@Deprecated(since = "2.519")
28402840
public ExtensionList getExtensionList(String extensionType) throws ClassNotFoundException {
28412841
return getExtensionList(pluginManager.uberClassLoader.loadClass(extensionType));
28422842
}

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"css-loader": "7.1.2",
3333
"css-minimizer-webpack-plugin": "7.0.2",
3434
"eslint": "9.31.0",
35-
"eslint-config-prettier": "10.1.5",
35+
"eslint-config-prettier": "10.1.8",
3636
"eslint-formatter-checkstyle": "8.40.0",
3737
"globals": "16.3.0",
3838
"handlebars-loader": "1.7.3",
@@ -45,7 +45,7 @@
4545
"sass": "1.89.2",
4646
"sass-loader": "16.0.5",
4747
"style-loader": "4.0.0",
48-
"stylelint": "16.21.1",
48+
"stylelint": "16.22.0",
4949
"stylelint-checkstyle-reporter": "1.1.1",
5050
"stylelint-config-standard-scss": "15.0.1",
5151
"webpack": "5.100.2",

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ THE SOFTWARE.
7373
</issueManagement>
7474

7575
<properties>
76-
<revision>2.520</revision>
76+
<revision>2.521</revision>
7777
<changelist>-SNAPSHOT</changelist>
78-
<project.build.outputTimestamp>2025-07-15T13:07:49Z</project.build.outputTimestamp>
78+
<project.build.outputTimestamp>2025-07-22T13:07:51Z</project.build.outputTimestamp>
7979

8080
<!-- configuration for patch tracker plugin -->
8181
<project.patchManagement.system>github</project.patchManagement.system>

test/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ THE SOFTWARE.
126126
<dependency>
127127
<groupId>org.jenkins-ci.plugins.workflow</groupId>
128128
<artifactId>workflow-api</artifactId>
129-
<version>1373.v7b_813f10efa_b_</version>
129+
<version>1380.ve03e7a_63d139</version>
130130
</dependency>
131131
<dependency>
132132
<groupId>org.jenkins-ci.plugins.workflow</groupId>

war/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ THE SOFTWARE.
324324
<!-- dependency of junit, plugin-util-api, and workflow-support -->
325325
<groupId>org.jenkins-ci.plugins.workflow</groupId>
326326
<artifactId>workflow-api</artifactId>
327-
<version>1373.v7b_813f10efa_b_</version>
327+
<version>1380.ve03e7a_63d139</version>
328328
<type>hpi</type>
329329
</artifactItem>
330330
<artifactItem>
@@ -390,7 +390,7 @@ THE SOFTWARE.
390390
<!-- dependency of script-security and workflow-support -->
391391
<groupId>io.jenkins.plugins</groupId>
392392
<artifactId>caffeine-api</artifactId>
393-
<version>3.2.0-166.v72a_6d74b_870f</version>
393+
<version>3.2.2-178.v353b_8428ed56</version>
394394
<type>hpi</type>
395395
</artifactItem>
396396

yarn.lock

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3500,14 +3500,14 @@ __metadata:
35003500
languageName: node
35013501
linkType: hard
35023502

3503-
"eslint-config-prettier@npm:10.1.5":
3504-
version: 10.1.5
3505-
resolution: "eslint-config-prettier@npm:10.1.5"
3503+
"eslint-config-prettier@npm:10.1.8":
3504+
version: 10.1.8
3505+
resolution: "eslint-config-prettier@npm:10.1.8"
35063506
peerDependencies:
35073507
eslint: ">=7.0.0"
35083508
bin:
35093509
eslint-config-prettier: bin/cli.js
3510-
checksum: 10c0/5486255428e4577e8064b40f27db299faf7312b8e43d7b4bc913a6426e6c0f5950cd519cad81ae24e9aecb4002c502bc665c02e3b52efde57af2debcf27dd6e0
3510+
checksum: 10c0/e1bcfadc9eccd526c240056b1e59c5cd26544fe59feb85f38f4f1f116caed96aea0b3b87868e68b3099e55caaac3f2e5b9f58110f85db893e83a332751192682
35113511
languageName: node
35123512
linkType: hard
35133513

@@ -4389,7 +4389,7 @@ __metadata:
43894389
css-loader: "npm:7.1.2"
43904390
css-minimizer-webpack-plugin: "npm:7.0.2"
43914391
eslint: "npm:9.31.0"
4392-
eslint-config-prettier: "npm:10.1.5"
4392+
eslint-config-prettier: "npm:10.1.8"
43934393
eslint-formatter-checkstyle: "npm:8.40.0"
43944394
globals: "npm:16.3.0"
43954395
handlebars: "npm:4.7.8"
@@ -4407,7 +4407,7 @@ __metadata:
44074407
sass-loader: "npm:16.0.5"
44084408
sortablejs: "npm:1.15.6"
44094409
style-loader: "npm:4.0.0"
4410-
stylelint: "npm:16.21.1"
4410+
stylelint: "npm:16.22.0"
44114411
stylelint-checkstyle-reporter: "npm:1.1.1"
44124412
stylelint-config-standard-scss: "npm:15.0.1"
44134413
tippy.js: "npm:6.3.7"
@@ -6729,9 +6729,9 @@ __metadata:
67296729
languageName: node
67306730
linkType: hard
67316731

6732-
"stylelint@npm:16.21.1":
6733-
version: 16.21.1
6734-
resolution: "stylelint@npm:16.21.1"
6732+
"stylelint@npm:16.22.0":
6733+
version: 16.22.0
6734+
resolution: "stylelint@npm:16.22.0"
67356735
dependencies:
67366736
"@csstools/css-parser-algorithms": "npm:^3.0.5"
67376737
"@csstools/css-tokenizer": "npm:^3.0.4"
@@ -6773,7 +6773,7 @@ __metadata:
67736773
write-file-atomic: "npm:^5.0.1"
67746774
bin:
67756775
stylelint: bin/stylelint.mjs
6776-
checksum: 10c0/32750d764411213d96e24f6a6e12af85f365ad4674214843068b39e02873adae927680c58e3ae14bc9d624899abe330819a53020bf3bd812821c3966678a3663
6776+
checksum: 10c0/706ba1f2f8d1c4c55347c2abbab661cf36cd6889af8afd200877cababf7f758e780d0e8a22ed1833542f487aeba08c30964b88dd6764c63953f7f232f5f4f114
67776777
languageName: node
67786778
linkType: hard
67796779

0 commit comments

Comments
 (0)