Fix race condition in pane collapse POST handling

Author: somiljain2006

core/src/main/resources/lib/form/link/link.js

@@ -1,14 +1,12 @@
 Behaviour.specify("A.post", "link.post", 0, function (element) {
-  const pendingHref = element.getAttribute("data-post-href");
-  if (pendingHref) {
-    element.setAttribute("href", pendingHref);
-    element.removeAttribute("data-post-href");
-  }
-
   element.onclick = function () {
-    var form = document.createElement("form");
+    const url = element.getAttribute("data-post-href") || element.getAttribute("href");
+    if (!url) {
+      return false;
+    }
+    const form = document.createElement("form");
     form.setAttribute("method", "POST");
-    form.setAttribute("action", element.getAttribute("href"));
+    form.setAttribute("action", url);
     crumb.appendToForm(form);
     document.body.appendChild(form);
     form.submit();

core/src/main/resources/lib/hudson/executors.jelly

@@ -23,7 +23,9 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 THE SOFTWARE.
 -->
 <?jelly escape-by-default='true'?>
-<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:local="local">
+<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout"
+         xmlns:t="/lib/hudson"
+         xmlns:local="local">
   <st:documentation>
     Displays the status of executors.
     <st:attribute name="computers">
@@ -176,7 +178,7 @@ THE SOFTWARE.
       </j:if>
       <st:adjunct includes="lib.form.link.link"/>
       <!-- TODO improve l:link so the `a` can be changed to `l:link`. -->
-      <a class="collapse post" data-post-href="${rootURL}/toggleCollapse?paneId=executors"
+        <a class="collapse post" href="#" data-post-href="${rootURL}/toggleCollapse?paneId=executors"
          tooltip="${paneIsCollapsed ? '%Expand' : '%Collapse'}" data-tooltip-append-to-parent="true">
         <j:set var="svgIconId" value="${paneIsCollapsed ? 'chevron-up' : 'chevron-down'}" />
         <l:icon src="symbol-${svgIconId}" />

core/src/main/resources/lib/layout/pane.jelly

@@ -61,7 +61,7 @@ THE SOFTWARE.
       <j:if test="${attrs.id != null}">
         <st:adjunct includes="lib.form.link.link"/>
         <!-- TODO improve l:link so the `a` can be changed to `l:link`. -->
-        <a class="collapse post" data-post-href="${rootURL}/toggleCollapse?paneId=${attrs.id}"
+          <a class="collapse post" href="#" data-post-href="${rootURL}/toggleCollapse?paneId=${attrs.id}"
            title="${paneIsCollapsed ? '%expand' : '%collapse'}">
 
           <j:set var="svgIconId" value="${paneIsCollapsed ? 'chevron-up' : 'chevron-down'}" />