Skip to content

Commit fab959f

Browse files
Fix keyboard navigation scrolling in dropdowns (#26358)
Co-authored-by: Tim Jacomb <timjacomb1@gmail.com>
1 parent ef7e6e6 commit fab959f

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

src/main/js/util/keyboard.js

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -82,22 +82,10 @@ export default function makeKeyboardNavigable(
8282

8383
function scrollAndSelect(selectedItem, selectedClass, items) {
8484
if (selectedItem) {
85-
if (!isInViewport(selectedItem)) {
86-
selectedItem.scrollIntoView(false);
87-
}
85+
selectedItem.scrollIntoView({ block: "nearest", behavior: "smooth" });
8886
selectedItem.classList.add(selectedClass);
8987
if (items.includes(document.activeElement)) {
9088
selectedItem.focus();
9189
}
9290
}
9391
}
94-
95-
function isInViewport(element) {
96-
const rect = element.getBoundingClientRect();
97-
return (
98-
rect.top >= 0 &&
99-
rect.left >= 0 &&
100-
rect.bottom <= window.innerHeight &&
101-
rect.right <= window.innerWidth
102-
);
103-
}

0 commit comments

Comments
 (0)