Skip to content

Commit fdf51d2

Browse files
committed
fix: available and installed plugins now correctly renders the shutdown banner
1 parent f1c01d0 commit fdf51d2

File tree

5 files changed

+10
-5
lines changed

5 files changed

+10
-5
lines changed

core/src/main/resources/hudson/PluginManager/available.jelly

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ THE SOFTWARE.
3232
<!-- no need for additional breadcrumb here as the side panel offers enough functionality to browse between different pages -->
3333

3434
<l:main-panel>
35-
<div class="jenkins-app-bar ${app.isQuietingDown() ? '' : 'jenkins-app-bar--sticky'}">
35+
<div class="jenkins-app-bar jenkins-app-bar--sticky">
3636
<div class="jenkins-app-bar__content">
3737
<l:search-bar clazz="jenkins-search--app-bar"
3838
placeholder="${%Search available plugins}"

core/src/main/resources/hudson/PluginManager/installed.jelly

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ THE SOFTWARE.
3737
<j:set var="noPlugins"
3838
value="${empty(app.pluginManager.plugins) and empty(app.pluginManager.failedPlugins)}" />
3939

40-
<div class="jenkins-app-bar ${app.isQuietingDown() ? '' : 'jenkins-app-bar--sticky'}">
40+
<div class="jenkins-app-bar jenkins-app-bar--sticky">
4141
<div class="jenkins-app-bar__content">
4242
<l:search-bar clazz="jenkins-search--app-bar"
4343
placeholder="${%Search installed plugins}"

core/src/main/resources/hudson/PluginManager/updates.jelly

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ THE SOFTWARE.
3535
</l:header>
3636

3737
<l:main-panel>
38-
<div class="jenkins-app-bar ${app.isQuietingDown() ? '' : 'jenkins-app-bar--sticky'}" style="${app.isQuietingDown() ? 'position: static !important;' : ''}">
38+
<div class="jenkins-app-bar jenkins-app-bar--sticky">
3939
<div class="jenkins-app-bar__content">
4040
<l:search-bar clazz="jenkins-search--app-bar"
4141
placeholder="${%Search plugin updates}"

core/src/main/resources/lib/layout/layout.jelly

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ THE SOFTWARE.
153153
<script src="${resURL}/jsbundles/sortable-drag-drop.js" type="text/javascript"/>
154154
<script src="${resURL}/jsbundles/app.js" type="text/javascript" defer="true" />
155155
</head>
156-
<body id="jenkins" class="${layoutType} jenkins-${h.version}" data-version="${h.version}" data-model-type="${it.class.name}"
156+
<body id="jenkins" class="${layoutType} jenkins-${h.version} ${app.isQuietingDown() ? 'jenkins-quieting-down' : ''}" data-version="${h.version}" data-model-type="${it.class.name}"
157157
data-search-url="${rootURL + '/search/suggest'}"
158158
data-search-help-url="${%searchBox.url}">
159159
<l:command-palette />

src/main/scss/components/_app-bar.scss

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,10 +115,15 @@
115115
}
116116
}
117117

118+
.jenkins-quieting-down .jenkins-app-bar--sticky {
119+
position: static !important;
120+
}
121+
118122
.jenkins-build-caption {
119123
display: flex;
120124
flex-direction: row !important;
121-
align-items: center;
125+
align-items: center !important;
126+
122127
justify-content: start !important;
123128
gap: 0.875rem;
124129
max-width: 1200px;

0 commit comments

Comments
 (0)