Update to hotkeys to v4

[NotMyFault]

The following BOM issue needs to be resolved in order to update the dependency:

• Update dependency org.jenkins-ci.main:jenkins-war to v2.491 bom#4114 (comment)

Originally posted by @MarkEWaite in #26013 (review)

[parshant4597]

Hello, I’m going through the project and getting familiar with the codebase. Could you please provide more context about this issue? If it is suitable for beginners, I would be happy to contribute.
My portfolio (just for background): https://parshantgoyal.vercel.app/
Thanks!

[MarkEWaite]

Hello, I’m going through the project and getting familiar with the codebase. Could you please provide more context about this issue? If it is suitable for beginners, I would be happy to contribute.

Thanks for your interest. Unfortunately, it is not suitable for a new contributor.

The issue involves multiple repositories, lots of reading, interactive testing to confirm things are still working correctly, multiple runs of large builds, and working with the maintainer of the HTMLUnit testing library to improve that library. The upgrade to hotkeys-js 4 needs to be tested interactively from a local build of the hotkeys-js 4.0.0 pull request. Once it is confirmed that the interactive tests pass, then the 600+ automated test failures in that pull request need to be investigated and fixed. They are likely to need improvements to the HTMLUnit testing library. Once the HTMLUnit testing library has been improved, then the HTMLUnit testing library needs to be included in the Jenkins test harness HTMLUnit library, which then needs to be included in the Jenkins test harness, which then needs to be included in Jenkins core and in the Jenkins plugin bill of materials.

We discovered that changes in hotkeys.js broke the automated tests in the plugin bill of materials as a result of Jenkins core pull request:

• Update dependency hotkeys-js to v3.13.9 #8769

The failure was detected in plugin BOM pull request:

• Update dependency org.jenkins-ci.main:jenkins-war to v2.491 bom#4114

The Jenkins core upgrade was reverted in pull request:

• Revert "Update dependency hotkeys-js to v3.13.9" #10070

The hotkeys-js 4.0.0 release is proposed for inclusion in Jenkins core by pull request:

• Update dependency hotkeys-js to v4 #26013

Before that pull request can be merged into Jenkins core, the 600+ test failures in that pull request need to be resolved, the incremental build from the pull request needs to be tested in the plugin BOM, and the incremental build from that pull request needs to be tested in the Jenkins acceptance test harness.

Most of the 600+ test failures look like this:

======= EXCEPTION START ========
Exception class=[org.htmlunit.corejs.javascript.EvaluatorException]
org.htmlunit.ScriptException: syntax error (http://localhost:33081/jenkins/static/ff299389/jsbundles/vendors.js#785)
	at org.htmlunit.javascript.JavaScriptEngine$HtmlUnitCompileContextAction.run(JavaScriptEngine.java:892)
	at org.htmlunit.corejs.javascript.Context.call(Context.java:636)

[Heller07]

Hi
I’ve started investigating the test failures triggered by the hotkeys-js v4 upgrade. I’m currently focusing on reproducing the HtmlUnit ScriptException: syntax error coming from vendors.js, and isolating which modern JavaScript syntax emitted by hotkeys-js v4 is not yet supported by HtmlUnit.
My plan is to first create a minimal HtmlUnit reproduction outside of Jenkins, then work with that to determine whether the fix belongs in HtmlUnit itself (preferred) or whether a short-term workaround is needed in the Jenkins build/test harness.
I’ll share concrete findings (failing snippet / minimal test case) once I have them. Please let me know if there’s a specific area you’d prefer me to focus on first.