Fix NullPointerException in LazyBuildMixIn on jenkins reload#26399
Merged
timja merged 1 commit intojenkinsci:masterfrom Mar 4, 2026
Merged
Fix NullPointerException in LazyBuildMixIn on jenkins reload#26399timja merged 1 commit intojenkinsci:masterfrom
timja merged 1 commit intojenkinsci:masterfrom
Conversation
timja
approved these changes
Mar 3, 2026
Member
timja
left a comment
There was a problem hiding this comment.
Thanks for sorting so quickly. I've tweaked the changelog entry a bit, not entirely happy with but I think its better than before.
jglick
approved these changes
Mar 3, 2026
Member
jglick
left a comment
There was a problem hiding this comment.
To be clear, is this reverting all or part of some specific prior PR?
Contributor
Author
I would say that it's re-work of #11038 |
Member
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
|
Thanks for getting this fix done so quickly. I'm not too familiar with your LTS build cut-off dates but assuming it gets merged this week is it likely to make it into 2.541.3 in a couple of weeks from now? |
Member
|
see #26397 (comment) |
NotMyFault
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26397
This PR removes the lazy loading behavior of RunMap’s entry.getValue(). The value will now be resolved inside iterator.next() instead of in entry.getValue() itself.
The weak semantics will be preserved for keySet() iteration, allowing iteration without resolving values on each step. Values can still be resolved explicitly by calling RunMap.get(someKey).
Testing done
Only jenkins integration tests. It is hard to reproduce the issue
Screenshots (UI changes only)
Before
After
Proposed changelog entries
RunMapthat causes issues when reloadingProposed changelog category
/label regression-fix
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jglick
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.