Security/client http redirect validation#26401
Open
YoussefAhmed256 wants to merge 3 commits intojenkinsci:masterfrom
Open
Security/client http redirect validation#26401YoussefAhmed256 wants to merge 3 commits intojenkinsci:masterfrom
YoussefAhmed256 wants to merge 3 commits intojenkinsci:masterfrom
Conversation
|
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
Author
|
@MarkEWaite take a look |
Contributor
It will be two weeks or more before I look at it. I'm on vacation for the next week. When I return, I have other tasks that are higher priority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26387 >
Implement URL validation and security checks in ClientHttpRedirect by restricting redirects to HTTP/HTTPS and relative paths only.
Added a null check for redirectUrl to prevent invalid usage and fail fast.
Also added a dedicated test class with unit tests covering allowed and blocked redirect scenarios.
Testing done
Screenshots (UI changes only)
Before
After
i tested it with script because there is no function that uses this class yet
Proposed changelog entries
/label skip-changelog
Proposed changelog category
/label bu
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.