Code style improvements (#762)

Fixes #758

* Code style improvements

* Remove Google code style

Author: zbynek

.gitignore

@@ -16,7 +16,5 @@ work/
 *.iml
 .vscode/
 .idea/*
-!.idea/checkstyle-idea.xml
-!.idea/google-java-format.xml
 
 atlassian-ide-plugin.xml

.idea/checkstyle-idea.xml

@@ -27,10 +27,10 @@ public JiraBuildAction(@NonNull Set<JiraIssue> issues) {
 
     // Leave it in place for binary compatibility.
     /**
-     * @deprecated use {@link #JiraBuildAction(java.util.Set)} instead
-     *
      * @param owner the owner of this action
      * @param issues the Jira issues
+     *
+     * @deprecated use {@link #JiraBuildAction(java.util.Set)} instead
      */
     @Deprecated
     public JiraBuildAction(Run<?, ?> owner, @NonNull Set<JiraIssue> issues) {

.idea/google-java-format.xml

@@ -30,7 +30,6 @@ public class JiraChangeLogAnnotator extends ChangeLogAnnotator {
     private static final Logger LOGGER = Logger.getLogger(JiraChangeLogAnnotator.class.getName());
 
     public JiraChangeLogAnnotator() {
-        super();
         LOGGER.fine("JiraChangeLogAnnotator created");
     }
 

src/main/java/hudson/plugins/jira/JiraBuildAction.java

@@ -185,11 +185,11 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
      * assignee,components and summary.
      * The created issue ID is saved to the file at "filename".
      *
-     * @param build
-     * @param filename
+     * @param build build
+     * @param filename filename
      * @return issue id
-     * @throws IOException
-     * @throws InterruptedException
+     * @throws IOException if IO fails
+     * @throws InterruptedException if thread is interrupted
      */
     private Issue createJiraIssue(AbstractBuild<?, ?> build, String filename) throws IOException, InterruptedException {
 
@@ -227,10 +227,10 @@ private Issue createJiraIssue(AbstractBuild<?, ?> build, String filename) throws
     /**
      * Returns the status of the issue.
      *
-     * @param build
-     * @param id
+     * @param build build
+     * @param id issue key
      * @return Status of the issue
-     * @throws IOException
+     * @throws IOException if IO fails
      */
     private Status getStatus(AbstractBuild<?, ?> build, String id) throws IOException {
 
@@ -242,11 +242,11 @@ private Status getStatus(AbstractBuild<?, ?> build, String id) throws IOExceptio
     /**
      * Adds a comment to the existing issue.
      *
-     * @param build
-     * @param listener
-     * @param id
-     * @param comment
-     * @throws IOException
+     * @param build build
+     * @param listener listener
+     * @param id issue key
+     * @param comment comment text
+     * @throws IOException if IO fails
      */
     private void addComment(AbstractBuild<?, ?> build, BuildListener listener, String id, String comment)
             throws IOException {
@@ -258,10 +258,10 @@ private void addComment(AbstractBuild<?, ?> build, BuildListener listener, Strin
     /**
      * Returns the issue id
      *
-     * @param filename
-     * @return
-     * @throws IOException
-     * @throws InterruptedException
+     * @param filename file from which to read the issue name
+     * @return issue ID
+     * @throws IOException if IO fails
+     * @throws InterruptedException if thread is interrupted
      */
     private String getIssue(String filename) throws IOException, InterruptedException {
         String issueId = "";
@@ -288,9 +288,9 @@ JiraSite getSiteForProject(AbstractProject<?, ?> project) {
     /**
      * Returns the jira session.
      *
-     * @param build
+     * @param build build
      * @return JiraSession
-     * @throws IOException
+     * @throws IOException if IO fails
      */
     private JiraSession getJiraSession(AbstractBuild<?, ?> build) throws IOException {
 
@@ -310,7 +310,7 @@ private JiraSession getJiraSession(AbstractBuild<?, ?> build) throws IOException
     }
 
     /**
-     * @param filename
+     * @param filename filename
      */
     private void deleteFile(String filename) {
         File file = new File(filename);
@@ -320,11 +320,11 @@ private void deleteFile(String filename) {
     }
 
     /**
-     * write's the issue id in the file, which is stored in the Job's directory
+     * Writes the issue id in the file, which is stored in the Job's directory.
      *
-     * @param filename
-     * @param issue
-     * @throws FileNotFoundException
+     * @param filename filenam
+     * @param issue issue
+     * @throws FileNotFoundException if file not found
      */
     private void writeInFile(String filename, Issue issue) throws IOException {
         // olamy really weird to write an empty file especially with null
@@ -394,12 +394,12 @@ private void currentBuildResultFailure(
      * it checks for the previous build's result and adds comment until the
      * previously created issue is closed.
      *
-     * @param build
-     * @param previousBuildResult
-     * @param filename
-     * @param vars
-     * @throws InterruptedException
-     * @throws IOException
+     * @param build build
+     * @param previousBuildResult previous build result
+     * @param filename filename
+     * @param vars variables
+     * @throws InterruptedException if thread isinterrupted
+     * @throws IOException if IO fails
      */
     private void currentBuildResultSuccess(
             AbstractBuild<?, ?> build,
@@ -463,8 +463,8 @@ private void progressWorkflowAction(AbstractBuild<?, ?> build, String issueId, I
     /**
      * Returns build details string in wiki format, with hyperlinks.
      *
-     * @param vars
-     * @return
+     * @param vars environment variables
+     * @return build details string
      */
     private String getBuildDetailsString(EnvVars vars) {
         final String buildURL = vars.get("BUILD_URL");
@@ -474,8 +474,8 @@ private String getBuildDetailsString(EnvVars vars) {
     /**
      * Returns build name in format BUILD#10
      *
-     * @param vars
-     * @return String
+     * @param vars environment variables
+     * @return String build name
      */
     private String getBuildName(EnvVars vars) {
         final String jobName = vars.get("JOB_NAME");

src/main/java/hudson/plugins/jira/JiraChangeLogAnnotator.java

@@ -36,9 +36,8 @@ public JiraSite[] getSites() {
     }
 
     /**
-     * @deprecated use {@link #setSites(List)} instead
-     *
      * @param site the Jira site
+     * @deprecated use {@link #setSites(List)} instead
      */
     @Deprecated
     public void setSites(JiraSite site) {

src/main/java/hudson/plugins/jira/JiraCreateIssueNotifier.java

@@ -112,7 +112,7 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
 
             JiraSite site = getJiraSiteForProject(build.getProject());
 
-            if (addRelease == true) {
+            if (addRelease) {
                 site.addFixVersionToIssue(realProjectKey, realRelease, realQuery);
             } else {
                 if (realReplace == null || realReplace.isEmpty()) {

src/main/java/hudson/plugins/jira/JiraFolderProperty.java

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package hudson.plugins.jira;
 
 import com.atlassian.jira.rest.client.api.RestClientException;

src/main/java/hudson/plugins/jira/JiraIssueMigrator.java

@@ -42,7 +42,6 @@ public class JiraIssueUpdater extends Recorder implements MatrixAggregatable, Si
 
     @DataBoundConstructor
     public JiraIssueUpdater(AbstractIssueSelector issueSelector, SCM scm, List<String> labels) {
-        super();
         this.issueSelector = issueSelector;
         this.scm = scm;
         if (labels != null) {