Merge pull request #1151 from jonesbusy/plugin-modernizer/migratecommonslang2tolang3andcommontext

Migrate Commons Lang from 2 to 3

Author: rantoniuk

pom.xml

@@ -59,6 +59,7 @@
     <jenkins.version>${jenkins.baseline}.3</jenkins.version>
     <spotless.check.skip>false</spotless.check.skip>
     <ban-junit4-imports.skip>false</ban-junit4-imports.skip>
+    <ban-commons-lang-2.skip>false</ban-commons-lang-2.skip>
   </properties>
 
   <dependencyManagement>

src/main/java/com/atlassian/httpclient/apache/httpcomponents/ApacheAsyncHttpClient.java

@@ -39,7 +39,7 @@
 import javax.net.ssl.SSLSession;
 import javax.net.ssl.SSLSocket;
 import jenkins.model.Jenkins;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.http.Header;
 import org.apache.http.HttpEntity;
 import org.apache.http.HttpException;

src/main/java/hudson/plugins/jira/CredentialsHelper.java

@@ -27,7 +27,7 @@
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import jenkins.model.Jenkins;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 
 /**
  * Helper class for vary credentials operations.

src/main/java/hudson/plugins/jira/JiraChangeLogAnnotator.java

@@ -17,7 +17,7 @@
 import java.util.logging.Logger;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 
 /**
  * {@link ChangeLogAnnotator} that picks up Jira issue IDs.

src/main/java/hudson/plugins/jira/JiraCreateIssueNotifier.java

@@ -36,7 +36,7 @@
 import java.util.logging.Logger;
 import java.util.stream.Collectors;
 import net.sf.json.JSONObject;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.stapler.AncestorInPath;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.QueryParameter;

src/main/java/hudson/plugins/jira/JiraCreateReleaseNotes.java

@@ -1,7 +1,7 @@
 package hudson.plugins.jira;
 
-import static org.apache.commons.lang.StringUtils.defaultIfEmpty;
-import static org.apache.commons.lang.StringUtils.isEmpty;
+import static org.apache.commons.lang3.StringUtils.defaultIfEmpty;
+import static org.apache.commons.lang3.StringUtils.isEmpty;
 
 import hudson.EnvVars;
 import hudson.Extension;

src/main/java/hudson/plugins/jira/JiraEnvironmentVariableBuilder.java

@@ -13,7 +13,7 @@
 import java.io.IOException;
 import java.util.Set;
 import jenkins.model.Jenkins;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.stapler.DataBoundConstructor;
 
 /**

src/main/java/hudson/plugins/jira/JiraIssueUpdateBuilder.java

@@ -26,7 +26,7 @@
 import hudson.util.FormValidation;
 import java.io.IOException;
 import jenkins.tasks.SimpleBuildStep;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.QueryParameter;

src/main/java/hudson/plugins/jira/JiraRestService.java

@@ -71,7 +71,7 @@
 import java.util.stream.StreamSupport;
 import jenkins.model.Jenkins;
 import org.apache.commons.codec.binary.Base64;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.http.HttpHost;
 import org.apache.http.client.fluent.Content;
 import org.apache.http.client.fluent.Request;

src/main/java/hudson/plugins/jira/JiraSession.java

@@ -1,6 +1,6 @@
 package hudson.plugins.jira;
 
-import static org.apache.commons.lang.StringUtils.isNotEmpty;
+import static org.apache.commons.lang3.StringUtils.isNotEmpty;
 
 import com.atlassian.jira.rest.client.api.RestClientException;
 import com.atlassian.jira.rest.client.api.domain.BasicIssue;
@@ -28,7 +28,7 @@
 import java.util.logging.Logger;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 
 /**
  * Connection to Jira.