Merge pull request #509 from gcuisinier/use-noproxyhost-configuration

Use No Proxy Hosts configuration, fixes #459

Author: rantoniuk

src/main/java/hudson/plugins/jira/JiraRestService.java

@@ -445,7 +445,13 @@ private Request buildGetRequest(URI uri) {
         ProxyConfiguration proxyConfiguration = Jenkins.get().proxy;
         if ( proxyConfiguration != null ) {
             final HttpHost proxyHost = new HttpHost( proxyConfiguration.name, proxyConfiguration.port );
-            request.viaProxy(proxyHost);
+
+            boolean shouldByPassProxy = proxyConfiguration.getNoProxyHostPatterns().stream().anyMatch(
+                    it -> it.matcher(uri.getHost()).matches()
+            );
+
+            if(!shouldByPassProxy)
+                request.viaProxy(proxyHost);
         }
 
         return request

src/test/java/hudson/plugins/jira/JiraRestServiceProxyTest.java

@@ -63,6 +63,18 @@ public void withProxy() throws Exception {
     assertEquals(localPort, proxyHost.getPort());
   }
 
+  @Test
+  public void withProxyAndNoProxyHosts() throws Exception {
+    int localPort = connector.getLocalPort();
+    Jenkins.get().proxy = new ProxyConfiguration("localhost", localPort);
+    Jenkins.get().proxy.setNoProxyHost("example.com|google.com");
+
+
+    assertNull(getProxyObjectFromRequest());
+
+  }
+
+
   @Test
   public void withoutProxy() throws Exception {
     assertNull(getProxyObjectFromRequest());
@@ -76,7 +88,7 @@ private Object getProxyObjectFromRequest()
     Method m = service.getClass().getDeclaredMethod("buildGetRequest", URI.class);
     m.setAccessible(true);
 
-    Request buildGetRequestValue = (Request) m.invoke(service, URI.create(""));
+    Request buildGetRequestValue = (Request) m.invoke(service, JIRA_URI);
 
     assertNotNull(buildGetRequestValue);