fix remaining MAX_VALUE instances in the codebase

fixes #654
replaces #655

Author: rantoniuk

src/main/java/hudson/plugins/jira/JiraSession.java

@@ -39,6 +39,8 @@
 public class JiraSession {
     private static final Logger LOGGER = Logger.getLogger(JiraSession.class.getName());
 
+    public static final Integer MAX_ISSUES = 100;
+
     public final JiraRestService service;
 
     /**
@@ -129,7 +131,7 @@ public Issue getIssue(String id) {
      * @return issues matching the JQL query
      */
     public List<Issue> getIssuesFromJqlSearch(final String jqlSearch) throws TimeoutException {
-        return service.getIssuesFromJqlSearch(jqlSearch, 100);
+        return service.getIssuesFromJqlSearch(jqlSearch, MAX_ISSUES);
     }
 
     /**
@@ -173,10 +175,11 @@ public List<Issue> getIssuesWithFixVersion(String projectKey, String version, St
         LOGGER.fine("Fetching versions from project: " + projectKey + " with fixVersion:" + version);
         if (isNotEmpty(filter)) {
             return service.getIssuesFromJqlSearch(
-                    String.format("project = \"%s\" and fixVersion = \"%s\" and " + filter, projectKey, version), 100);
+                    String.format("project = \"%s\" and fixVersion = \"%s\" and " + filter, projectKey, version),
+                    MAX_ISSUES);
         }
         return service.getIssuesFromJqlSearch(
-                String.format("project = \"%s\" and fixVersion = \"%s\"", projectKey, version), 100);
+                String.format("project = \"%s\" and fixVersion = \"%s\"", projectKey, version), MAX_ISSUES);
     }
 
     /**
@@ -223,7 +226,7 @@ public void migrateIssuesToFixVersion(String projectKey, String version, String
         }
 
         LOGGER.fine("Fetching versions with JQL:" + query);
-        List<Issue> issues = service.getIssuesFromJqlSearch(query, Integer.MAX_VALUE);
+        List<Issue> issues = service.getIssuesFromJqlSearch(query, MAX_ISSUES);
         if (issues == null || issues.isEmpty()) {
             return;
         }
@@ -253,7 +256,7 @@ public void replaceFixVersion(String projectKey, String fromVersion, String toVe
         }
 
         LOGGER.fine("Fetching versions with JQL:" + query);
-        List<Issue> issues = service.getIssuesFromJqlSearch(query, Integer.MAX_VALUE);
+        List<Issue> issues = service.getIssuesFromJqlSearch(query, MAX_ISSUES);
         if (issues == null) {
             return;
         }
@@ -306,7 +309,7 @@ public void addFixVersion(String projectKey, String version, String query) throw
         }
 
         LOGGER.fine("Fetching issues with JQL:" + query);
-        List<Issue> issues = service.getIssuesFromJqlSearch(query, Integer.MAX_VALUE);
+        List<Issue> issues = service.getIssuesFromJqlSearch(query, MAX_ISSUES);
         if (issues == null || issues.isEmpty()) {
             return;
         }

src/test/java/JiraTester.java

@@ -1,13 +1,13 @@
-import static hudson.plugins.jira.JiraSite.ExtendedAsynchronousJiraRestClientFactory;
-
 import com.atlassian.jira.rest.client.api.domain.Component;
 import com.atlassian.jira.rest.client.api.domain.Issue;
 import com.atlassian.jira.rest.client.api.domain.IssueType;
 import com.atlassian.jira.rest.client.api.domain.Status;
 import com.atlassian.jira.rest.client.api.domain.Transition;
 import com.atlassian.jira.rest.client.api.domain.User;
 import hudson.plugins.jira.JiraRestService;
+import hudson.plugins.jira.JiraSession;
 import hudson.plugins.jira.JiraSite;
+import hudson.plugins.jira.JiraSite.ExtendedAsynchronousJiraRestClientFactory;
 import hudson.plugins.jira.extension.ExtendedJiraRestClient;
 import hudson.plugins.jira.extension.ExtendedVersion;
 import java.net.URI;
@@ -103,7 +103,7 @@ public static void main(String[] args) throws Exception {
     private static void callUniq(final JiraRestService restService) throws Exception {
         long start = System.currentTimeMillis();
         List<Issue> issues =
-                restService.getIssuesFromJqlSearch("key in ('JENKINS-53320','JENKINS-51057')", Integer.MAX_VALUE);
+                restService.getIssuesFromJqlSearch("key in ('JENKINS-53320','JENKINS-51057')", JiraSession.MAX_ISSUES);
         long end = System.currentTimeMillis();
         System.out.println("time uniq " + (end - start));
     }
@@ -112,7 +112,7 @@ private static void callDuplicate(final JiraRestService restService) throws Exce
         long start = System.currentTimeMillis();
         List<Issue> issues = restService.getIssuesFromJqlSearch(
                 "key in ('JENKINS-53320','JENKINS-53320','JENKINS-53320','JENKINS-53320','JENKINS-53320','JENKINS-51057','JENKINS-51057','JENKINS-51057','JENKINS-51057','JENKINS-51057')",
-                Integer.MAX_VALUE);
+                JiraSession.MAX_ISSUES);
         long end = System.currentTimeMillis();
         System.out.println("time duplicate " + (end - start));
     }

src/test/java/JiraTesterBearerAuth.java

@@ -1,13 +1,13 @@
-import static hudson.plugins.jira.JiraSite.ExtendedAsynchronousJiraRestClientFactory;
-
 import com.atlassian.jira.rest.client.api.domain.Component;
 import com.atlassian.jira.rest.client.api.domain.Issue;
 import com.atlassian.jira.rest.client.api.domain.IssueType;
 import com.atlassian.jira.rest.client.api.domain.Status;
 import com.atlassian.jira.rest.client.api.domain.Transition;
 import com.atlassian.jira.rest.client.api.domain.User;
 import hudson.plugins.jira.JiraRestService;
+import hudson.plugins.jira.JiraSession;
 import hudson.plugins.jira.JiraSite;
+import hudson.plugins.jira.JiraSite.ExtendedAsynchronousJiraRestClientFactory;
 import hudson.plugins.jira.auth.BearerHttpAuthenticationHandler;
 import hudson.plugins.jira.extension.ExtendedJiraRestClient;
 import hudson.plugins.jira.extension.ExtendedVersion;
@@ -105,7 +105,7 @@ public static void main(String[] args) throws Exception {
     private static void callUniq(final JiraRestService restService) throws Exception {
         long start = System.currentTimeMillis();
         List<Issue> issues =
-                restService.getIssuesFromJqlSearch("key in ('JENKINS-53320','JENKINS-51057')", Integer.MAX_VALUE);
+                restService.getIssuesFromJqlSearch("key in ('JENKINS-53320','JENKINS-51057')", JiraSession.MAX_ISSUES);
         long end = System.currentTimeMillis();
         System.out.println("time uniq " + (end - start));
     }
@@ -114,7 +114,7 @@ private static void callDuplicate(final JiraRestService restService) throws Exce
         long start = System.currentTimeMillis();
         List<Issue> issues = restService.getIssuesFromJqlSearch(
                 "key in ('JENKINS-53320','JENKINS-53320','JENKINS-53320','JENKINS-53320','JENKINS-53320','JENKINS-51057','JENKINS-51057','JENKINS-51057','JENKINS-51057','JENKINS-51057')",
-                Integer.MAX_VALUE);
+                JiraSession.MAX_ISSUES);
         long end = System.currentTimeMillis();
         System.out.println("time duplicate " + (end - start));
     }

src/test/java/hudson/plugins/jira/JiraReplaceFixVersionByRegExTest.java

@@ -54,7 +54,7 @@ void replaceWithFixVersionByRegex() throws URISyntaxException, TimeoutException
         ArrayList<Issue> issues = new ArrayList<>();
         issues.add(getIssue("abcXXXXefg", 1L));
         issues.add(getIssue("dgcXXXXefg", 2L));
-        when(service.getIssuesFromJqlSearch(QUERY, Integer.MAX_VALUE)).thenReturn(issues);
+        when(service.getIssuesFromJqlSearch(QUERY, JiraSession.MAX_ISSUES)).thenReturn(issues);
 
         jiraSession.replaceFixVersion(PROJECT_KEY, "/abc.*efg/", TO_VERSION, QUERY);