Skip to content

Commit bed3adb

Browse files
committed
Merge branch '658-GetFixVersions' of https://github.com/davedevretro/jira-plugin into 658-GetFixVersions
2 parents 85113ab + 3199265 commit bed3adb

File tree

3 files changed

+35
-3
lines changed

3 files changed

+35
-3
lines changed

.mvn/maven.config

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
-Pconsume-incrementals
22
-Pmight-produce-incrementals
3+
-Dchangelist.format=%d.v%s

.pre-commit-config.yaml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
repos:
2+
- repo: https://github.com/pre-commit/pre-commit-hooks
3+
rev: v4.6.0
4+
hooks:
5+
- id: check-yaml
6+
- id: check-added-large-files
7+
- repo: https://github.com/ORCID/pre-commit-spotless
8+
rev: v1.0.0
9+
hooks:
10+
- id: spotless-check
11+
types_or: [java]
12+
- id: spotless-apply
13+
types_or: [java]

CONTRIBUTING.md

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,24 @@
1-
# Notes for maintainers
1+
# Contribution guidelines
22

3-
## Local testing
3+
General rules:
4+
5+
- check the [general Jenkins development guide](https://www.jenkins.io/doc/developer/book/)
6+
- make sure to provide tests
7+
- mark the Pull Request as _draft_ initially, to make sure all the checks pass correctly, then convert it to non-draft.
8+
9+
## Setting up your environment
10+
11+
### Install pre-commit hooks
12+
13+
The [pre-commit](https://pre-commit.com/#install) hooks run various checks to make sure no unwanted files are committed and that the submitted change follows the code style and formatting rules:
14+
15+
```sh
16+
brew install pre-commit && pre-commit install --install-hooks
17+
```
18+
19+
## Notes for maintainers
20+
21+
### Local testing
422

523
Use [docker-compose](./docker-compose.yml) to run a local Jenkins instance with the plugin installed. The configuration includes local volumes for both: Jenkins and ssh-agent, so you can easily test the plugin in a clean environment.
624

@@ -20,4 +38,4 @@ There is a [Jira Cloud](https://jenkins-jira-plugin.atlassian.net/) test instanc
2038
2139
### Releasing the plugin
2240
23-
Make sure you have your `~/.m2/settings.xml` configured accordingly - refer to [releasing Jenkins plugins](https://www.jenkins.io/doc/developer/publishing/releasing/).
41+
Make sure you have your `~/.m2/settings.xml` configured accordingly - refer to [releasing Jenkins plugins](https://www.jenkins.io/doc/developer/publishing/releasing/).

0 commit comments

Comments
 (0)