[contributing] Checkstyle setup for IntelliJ

[zbynek]

The Checkstyle setup in .idea folder defines Google style as active, so devs who use Checkstyle IntelliJ plugin se hundreds of warnings because "expected" indentation is 2 and real one is 4 spaces.

I would suggest either removing the file from Git if maintainers do not use this plugin or changing it in a way that works for Jenkins checkstyle config.

https://github.com/jenkinsci/jira-plugin/blob/master/.idea/checkstyle-idea.xml

[rantoniuk]

works for Jenkins checkstyle config

Which config do you have in mind?

[zbynek]

Maybe https://raw.githubusercontent.com/jenkinsci/jenkins/refs/tags/jenkins-2.516.3/src/checkstyle/checkstyle-configuration.xml ?

[rantoniuk]

I'm ok with removing this configuration altogether, but at the same time I would like to make sure that the IDE formatting (on-demand or on-save) is compliant with the linters coming from the plugin-pom. I don't use IntelliJ Idea anymore, but since you've opened this issue, I'm assuming you're still using it?

If removing the .idea folder resolves the issue and auto-formatted (in IDE) code is compliant with mvn spotless:check, then let's go for that.

[zbynek]

The list of linters you linked above is relevant for Jenkins core, the plugin POM does not bring any Checkstyle config. If this plugin were to use core's Checkstyle config, it would require code style changes proposed in #762 .

If removing the .idea folder resolves the issue and auto-formatted (in IDE) code is compliant with mvn spotless:check, then let's go for that.

That sounds like a good solution to me.