Skip to content

Commit f35a472

Browse files
authored
Use correct ClassLoader for Kafka. (#297)
Signed-off-by: Greg Allen <[email protected]>
1 parent b97f4d7 commit f35a472

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

plugin/src/main/java/com/redhat/jenkins/plugins/ci/messaging/ActiveMqMessagingWorker.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -445,8 +445,8 @@ public SendResult sendMessage(Run<?, ?> build, TaskListener listener, ProviderDa
445445
mesgId = message.getJMSMessageID();
446446
mesgContent = message.getText();
447447

448-
log.info("Sent message for job '" + build.getParent().getName() + "' to " + kind + " '" + ltopic + "':\n"
449-
+ formatMessage(message));
448+
log.info("Sent message for job '" + build.getParent().getName() + "' to " + kind + " '" + ltopic
449+
+ "':\n" + formatMessage(message));
450450
} else {
451451
log.severe("One or more of the following is invalid (null): user, password, topic, broker.");
452452
return new SendResult(false, mesgId, mesgContent);

plugin/src/main/java/com/redhat/jenkins/plugins/ci/messaging/KafkaMessagingProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,12 +181,12 @@ public FormValidation doTestConnection(@QueryParameter("topic") String topic,
181181
Properties cprops = getMergedConsumerProperties(consumerProperties);
182182

183183
ClassLoader original = Thread.currentThread().getContextClassLoader();
184-
Thread.currentThread().setContextClassLoader(null);
184+
Thread.currentThread().setContextClassLoader(KafkaConsumer.class.getClassLoader());
185185
try (KafkaConsumer consumer = new KafkaConsumer<>(cprops);
186186
KafkaProducer producer = new KafkaProducer<>(pprops)) {
187187

188188
// Test producer.
189-
ProducerRecord<String, String> record = new ProducerRecord<>("test-topic", "test-key", "test-value");
189+
ProducerRecord<String, String> record = new ProducerRecord<>(topic, "test-key", "test-value");
190190
producer.send(record).get();
191191

192192
// Test consumer.

plugin/src/main/java/com/redhat/jenkins/plugins/ci/messaging/KafkaMessagingWorker.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ public boolean connect() {
190190
// Invalid value org.apache.kafka.common.serialization.StringDeserializer for configuration
191191
// value.deserializer: Class org.apache.kafka.common.serialization.StringDeserializer could not be found.
192192
ClassLoader original = Thread.currentThread().getContextClassLoader();
193-
Thread.currentThread().setContextClassLoader(null);
193+
Thread.currentThread().setContextClassLoader(KafkaConsumer.class.getClassLoader());
194194
consumer = new KafkaConsumer<>(pdata.mergeProperties(provider.getMergedConsumerProperties()));
195195
Thread.currentThread().setContextClassLoader(original);
196196
}
@@ -222,7 +222,7 @@ public SendResult sendMessage(Run<?, ?> build, TaskListener listener, ProviderDa
222222
String body = "";
223223
String msgId = "";
224224
ClassLoader original = Thread.currentThread().getContextClassLoader();
225-
Thread.currentThread().setContextClassLoader(null);
225+
Thread.currentThread().setContextClassLoader(KafkaProducer.class.getClassLoader());
226226
try (KafkaProducer<String, String> producer = new KafkaProducer<>(
227227
pd.mergeProperties(provider.getMergedProducerProperties()))) {
228228
EnvVars env = new EnvVars();
@@ -278,7 +278,7 @@ public String waitForMessage(Run<?, ?> build, TaskListener listener, ProviderDat
278278
}
279279

280280
ClassLoader original = Thread.currentThread().getContextClassLoader();
281-
Thread.currentThread().setContextClassLoader(null);
281+
Thread.currentThread().setContextClassLoader(KafkaConsumer.class.getClassLoader());
282282
try (KafkaConsumer<String, String> lconsumer = new KafkaConsumer<>(
283283
pd.mergeProperties(provider.getMergedConsumerProperties()))) {
284284
int timeout = (pd.getTimeout() != null ? pd.getTimeout()

0 commit comments

Comments
 (0)