[fix_non_config_instance] add no-op methods for non readonly Kubernetes cloud (#1491)

* [fix_non_config_instance] add unimplemented methods for non config classes

Signed-off-by: Thorsten Scherler <[email protected]>

* [fix_non_config_instance] fix test

Signed-off-by: Thorsten Scherler <[email protected]>

* [fix_non_config_instance] add more tests

Signed-off-by: Thorsten Scherler <[email protected]>

* eslint - formating changes and fix offences

Signed-off-by: Thorsten Scherler <[email protected]>

---------

Signed-off-by: Thorsten Scherler <[email protected]>

Author: scherler

src/main/java/org/csanchez/jenkins/plugins/kubernetes/NonConfigurableKubernetesCloud.java

@@ -14,6 +14,20 @@ public NonConfigurableKubernetesCloud(@NonNull String name, @NonNull KubernetesC
         super(name, source);
     }
 
+    @Override
+    public void replaceTemplate(PodTemplate oldTemplate, PodTemplate newTemplate) {}
+
+    @Override
+    public void addTemplate(PodTemplate template) {}
+
+    @Override
+    public void removeTemplate(PodTemplate template) {}
+
+    @Override
+    public Cloud reconfigure(@NonNull StaplerRequest req, JSONObject form) throws Descriptor.FormException {
+        return DescriptorImpl.class.cast(getDescriptor()).newInstance(req, form);
+    }
+
     @Extension
     public static class FilterImpl extends DescriptorVisibilityFilter {
         @Override

src/test/java/org/csanchez/jenkins/plugins/kubernetes/NonConfigurableKubernetesCloudTest.java

@@ -0,0 +1,52 @@
+package org.csanchez.jenkins.plugins.kubernetes;
+
+import static org.junit.Assert.assertEquals;
+
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.junit.Rule;
+import org.junit.Test;
+import org.jvnet.hudson.test.JenkinsRule;
+import org.jvnet.hudson.test.LoggerRule;
+
+public class NonConfigurableKubernetesCloudTest {
+
+    @Rule
+    public JenkinsRule j = new JenkinsRule();
+
+    @Rule
+    public LoggerRule logs = new LoggerRule()
+            .record(
+                    Logger.getLogger(NonConfigurableKubernetesCloudTest.class
+                            .getPackage()
+                            .getName()),
+                    Level.ALL);
+
+    @Test
+    public void configRoundTrip() throws Exception {
+        // create a cloud with a template
+        var cloud = new KubernetesCloud("kubernetes");
+        var podTemplate = new PodTemplate();
+        podTemplate.setName("test-template");
+        podTemplate.setLabel("test");
+        cloud.addTemplate(podTemplate);
+        var jenkins = j.jenkins;
+        jenkins.clouds.add(cloud);
+        jenkins.save();
+        var readOnly = new NonConfigurableKubernetesCloud("NonConfigurableKubernetes", cloud);
+        readOnly.removeTemplate(podTemplate); // should not remove anything
+        var podTemplate2 = new PodTemplate();
+        podTemplate2.setName("test-template-read-only");
+        podTemplate2.setLabel("test-read-only");
+        readOnly.addTemplate(podTemplate2);
+        jenkins.clouds.add(readOnly);
+        jenkins.save();
+        assertEquals(2, jenkins.clouds.size()); // sanity check
+        assertEquals(1, readOnly.getTemplates().size()); // remove should not have removed anything, nor should have add
+        readOnly.getTemplates().forEach(t -> {
+            if (t.getName().equals("test-template-read-only")) {
+                throw new RuntimeException("Template should not be added");
+            }
+        });
+    }
+}