Skip to content

Commit 19ceafd

Browse files
authored
Revert "[JENKINS-76095] Schedule cleanup of expired clients (#1747)" (#1766)
1 parent 173a051 commit 19ceafd

1 file changed

Lines changed: 0 additions & 16 deletions

File tree

src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesClientProvider.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,8 @@
77
import hudson.XmlFile;
88
import hudson.model.Saveable;
99
import hudson.model.listeners.SaveableListener;
10-
import hudson.util.DaemonThreadFactory;
11-
import hudson.util.NamingThreadFactory;
1210
import io.fabric8.kubernetes.client.KubernetesClient;
1311
import java.io.IOException;
14-
import java.lang.ref.Cleaner;
1512
import java.util.Arrays;
1613
import java.util.HashSet;
1714
import java.util.Set;
@@ -97,25 +94,12 @@ public static int getValidity(@NonNull KubernetesCloud cloud) {
9794
}
9895

9996
private static class Client {
100-
101-
private static final Cleaner CLEANER = Cleaner.create(new NamingThreadFactory(
102-
new DaemonThreadFactory(), KubernetesClientProvider.class.getName() + ".Cleaner"));
103-
// Use Java Cleaner to ensure the client is closed eventually
10497
private final KubernetesClient client;
10598
private final int validity;
10699

107100
public Client(int validity, KubernetesClient client) {
108101
this.client = client;
109102
this.validity = validity;
110-
CLEANER.register(this, this::close);
111-
}
112-
113-
/**
114-
* Close the underlying client when the Client object is expired or GC'ed
115-
*/
116-
private void close() {
117-
LOGGER.log(Level.FINE, () -> "Closing expired client " + client);
118-
client.close();
119103
}
120104

121105
public KubernetesClient getClient() {

0 commit comments

Comments
 (0)