Use 'modern' checkUrl validation

This avoids 404 errors when attempting to validate the
startupTimesToRetryOnFailure and startupWaitingPeriodSeconds fields
when adding or editing a computer with Jenkins 2.541. This form is
available since Jenkins 2.360.

@see https://www.jenkins.io/doc/developer/security/csp/#legacy-javascript-checkurl-validation

Signed-off-by: Kienan Stewart <kstewart@efficios.com>

Author: kienanstewart

src/main/java/hudson/plugins/libvirt/PluginImpl.java

@@ -107,11 +107,11 @@ public Hypervisor getServer(final String host) {
     }
 
     @POST
-    public FormValidation doCheckStartupWaitingPeriodSeconds(@QueryParameter String secsValue)
+    public FormValidation doCheckStartupWaitingPeriodSeconds(@QueryParameter String value)
             throws IOException, ServletException {
         Jenkins.get().checkPermission(Jenkins.ADMINISTER);
         try {
-            int v = Integer.parseInt(secsValue);
+            int v = Integer.parseInt(value);
             if (v < 0) {
                 return FormValidation.error("Negative value..");
             } else if (v == 0) {
@@ -126,11 +126,11 @@ public FormValidation doCheckStartupWaitingPeriodSeconds(@QueryParameter String
     }
 
     @POST
-    public FormValidation doCheckStartupTimesToRetryOnFailure(@QueryParameter String retriesValue)
+    public FormValidation doCheckStartupTimesToRetryOnFailure(@QueryParameter String value)
             throws IOException, ServletException {
         Jenkins.get().checkPermission(Jenkins.ADMINISTER);
         try {
-            int v = Integer.parseInt(retriesValue);
+            int v = Integer.parseInt(value);
             if (v < 0) {
                 return FormValidation.error("Negative value.");
             } else {

src/main/resources/hudson/plugins/libvirt/VirtualMachineSlave/configure-entries.jelly

@@ -42,11 +42,11 @@
     </f:entry>
 
     <f:entry title="${%Startup Idle (sec)}" field="startupWaitingPeriodSeconds" help="/plugin/libvirt-slave/help-libvirt-waitingperiod.html">
-        <f:textbox checkMethod="post" default="60" checkUrl="'${rootURL}/plugin/libvirt-slave/checkStartupWaitingPeriodSeconds?secsValue='+this.value"/>
+        <f:textbox checkMethod="post" default="60" checkUrl="${rootURL}/plugin/libvirt-slave/checkStartupWaitingPeriodSeconds" checkDependsOn=""/>
     </f:entry>
 
     <f:entry title="${%Times to Retry Startup}" field="startupTimesToRetryOnFailure" help="/plugin/libvirt-slave/help-libvirt-timesToRetryOnFailure.html">
-        <f:textbox checkMethod="post" default="0" checkUrl="'${rootURL}/plugin/libvirt-slave/checkStartupTimesToRetryOnFailure?retriesValue='+this.value"/>
+        <f:textbox checkMethod="post" default="0" checkUrl="${rootURL}/plugin/libvirt-slave/checkStartupTimesToRetryOnFailure" checkDependsOn=""/>
     </f:entry>
 
     <f:entry title="${%# of executors}" field="numExecutors">