Remove dependency on commons-lang3-api plugin (#185)

Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>

Author: daniel-beck

pom.xml

@@ -61,10 +61,6 @@
       <artifactId>configuration-as-code</artifactId>
       <optional>true</optional>
     </dependency>
-    <dependency>
-      <groupId>io.jenkins.plugins</groupId>
-      <artifactId>commons-lang3-api</artifactId>
-    </dependency>
     <dependency>
       <groupId>io.jenkins.plugins</groupId>
       <artifactId>ionicons-api</artifactId>

src/main/java/org/jenkinsci/plugins/matrixauth/AuthorizationContainerDescriptor.java

@@ -18,7 +18,6 @@
 import java.util.List;
 import java.util.stream.Collectors;
 import jenkins.model.Jenkins;
-import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.DoNotUse;
 import org.kohsuke.accmod.restrictions.NoExternalUse;
@@ -93,7 +92,7 @@ default String impliedByList(Permission p) {
             p = p.impliedBy;
             impliedBys.add(p);
         }
-        return StringUtils.join(impliedBys.stream().map(Permission::getId).collect(Collectors.toList()), " ");
+        return impliedBys.stream().map(Permission::getId).collect(Collectors.joining(" "));
     }
 
     @Restricted(DoNotUse.class) // Called from Jelly view

src/main/java/org/jenkinsci/plugins/matrixauth/ValidationUtil.java

@@ -35,7 +35,6 @@
 import hudson.security.SecurityRealm;
 import hudson.security.UserMayOrMayNotExistException2;
 import hudson.util.FormValidation;
-import org.apache.commons.lang3.StringUtils;
 import org.jenkins.ui.symbol.Symbol;
 import org.jenkins.ui.symbol.SymbolRequest;
 import org.kohsuke.accmod.Restricted;
@@ -137,17 +136,15 @@ static FormValidation validateGroup(String groupName, SecurityRealm sr, boolean
                         FormValidation.Kind.WARNING,
                         formatUserGroupValidationResponse(
                                 GROUP,
-                                Util.escape(StringUtils.abbreviate(groupDetails.getDisplayName(), 50)),
+                                Util.escape(abbreviate(groupDetails.getDisplayName())),
                                 "Group " + escapedSid
                                         + " found; but permissions would also be granted to a user of this name",
                                 true));
             } else {
                 return FormValidation.respond(
                         FormValidation.Kind.OK,
                         formatUserGroupValidationResponse(
-                                GROUP,
-                                Util.escape(StringUtils.abbreviate(groupDetails.getDisplayName(), 50)),
-                                "Group " + escapedSid));
+                                GROUP, Util.escape(abbreviate(groupDetails.getDisplayName())), "Group " + escapedSid));
             }
         } catch (UserMayOrMayNotExistException2 e) {
             // undecidable, meaning the group may exist
@@ -196,15 +193,15 @@ static FormValidation validateUser(String userName, SecurityRealm sr, boolean am
                         FormValidation.Kind.WARNING,
                         formatUserGroupValidationResponse(
                                 USER,
-                                Util.escape(StringUtils.abbreviate(u.getFullName(), 50)),
+                                Util.escape(abbreviate(u.getFullName())),
                                 "User " + escapedSid
                                         + " found; but permissions would also be granted to a group of this name",
                                 true));
             } else {
                 return FormValidation.respond(
                         FormValidation.Kind.OK,
                         formatUserGroupValidationResponse(
-                                USER, Util.escape(StringUtils.abbreviate(u.getFullName(), 50)), "User " + escapedSid));
+                                USER, Util.escape(abbreviate(u.getFullName())), "User " + escapedSid));
             }
         } catch (UserMayOrMayNotExistException2 e) {
             // undecidable, meaning the user may exist
@@ -227,4 +224,15 @@ static FormValidation validateUser(String userName, SecurityRealm sr, boolean am
         }
         return null;
     }
+
+    private static String abbreviate(String str) {
+        if (str == null) {
+            return null;
+        }
+        final int length = str.length();
+        if (length <= 50) {
+            return str;
+        }
+        return str.substring(0, 47) + "...";
+    }
 }