Skip to content

Commit 7978729

Browse files
committed
Fixed SECURITY-2411
1 parent 1c9cd99 commit 7978729

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

Diff for: src/main/java/hudson/plugins/nested_view/NestedView.java

+8-4
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
import java.io.BufferedInputStream;
3232
import java.io.ByteArrayInputStream;
3333
import java.io.InputStream;
34+
35+
import javax.xml.XMLConstants;
3436
import javax.xml.transform.Transformer;
3537
import javax.xml.transform.TransformerException;
3638
import javax.xml.transform.TransformerFactory;
@@ -505,10 +507,12 @@ public void updateByXml(Source source) throws IOException {
505507
// this allows us to use UTF-8 for storing data,
506508
// plus it checks any well-formedness issue in the submitted
507509
// data
508-
Transformer t = TransformerFactory.newInstance()
509-
.newTransformer();
510-
t.transform(source,
511-
new StreamResult(out));
510+
TransformerFactory factory = TransformerFactory.newInstance();
511+
factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
512+
factory.setAttribute(XMLConstants.ACCESS_EXTERNAL_DTD, "");
513+
factory.setAttribute(XMLConstants.ACCESS_EXTERNAL_STYLESHEET, "");
514+
Transformer t = factory.newTransformer();
515+
t.transform(source, new StreamResult(out));
512516
out.close();
513517
} catch (TransformerException e) {
514518
throw new IOException2("Failed to persist configuration.xml", e);

0 commit comments

Comments
 (0)