set aria label for the plain text log link (#826)

Author: lewisbirks

src/main/frontend/common/i18n/i18n-provider.tsx

@@ -45,3 +45,7 @@ export const I18NProvider: FunctionComponent<I18NProviderProps> = ({
     <I18NContext.Provider value={messages}>{children}</I18NContext.Provider>
   );
 };
+
+export function useMessages() {
+  return useContext(I18NContext);
+}

src/main/frontend/common/i18n/messages.ts

@@ -81,6 +81,7 @@ export enum LocalizedMessageKey {
   start = "node.start",
   end = "node.end",
   changesSummary = "changes.summary",
+  consoleNewTab = "console.newTab",
 }
 
 const DEFAULT_MESSAGES: ResourceBundle = {
@@ -96,6 +97,7 @@ const DEFAULT_MESSAGES: ResourceBundle = {
   [LocalizedMessageKey.start]: "Start",
   [LocalizedMessageKey.end]: "End",
   [LocalizedMessageKey.changesSummary]: "{0} {0,choice,1#change|1<changes}",
+  [LocalizedMessageKey.consoleNewTab]: "View step as plain text",
 };
 
 export function defaultMessages(locale: string): Messages {

src/main/frontend/pipeline-console-view/pipeline-console/main/ConsoleLogCard.tsx

@@ -9,6 +9,7 @@ import {
 
 import StatusIcon from "../../../common/components/status-icon.tsx";
 import Tooltip from "../../../common/components/tooltip.tsx";
+import { LocalizedMessageKey, useMessages } from "../../../common/i18n";
 import { classNames } from "../../../common/utils/classnames.ts";
 import { Total } from "../../../common/utils/timings.tsx";
 import {
@@ -72,6 +73,8 @@ export default function ConsoleLogCard(props: ConsoleLogCardProps) {
     return `${(size / gib).toFixed(2)}GiB`;
   };
 
+  const messages = useMessages();
+
   return (
     <div className={"pgv-step-detail-group"} key={`step-card-${props.step.id}`}>
       <div
@@ -124,12 +127,13 @@ export default function ConsoleLogCard(props: ConsoleLogCardProps) {
           </div>
         </a>
 
-        <Tooltip content={"View step as plain text"}>
+        <Tooltip content={messages.format(LocalizedMessageKey.consoleNewTab)}>
           <a
             href={`log?nodeId=${props.step.id}`}
             className={"jenkins-button jenkins-button--tertiary"}
             target="_blank"
             rel="noreferrer"
+            aria-label={messages.format(LocalizedMessageKey.consoleNewTab)}
           >
             <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512">
               <path

src/main/resources/io/jenkins/plugins/pipelinegraphview/Messages.properties

@@ -33,3 +33,5 @@ FlowNodeWrapper.noStage=System Generated
 
 run.alreadyCancelled=Run was already cancelled
 run.isFinished=Run is already finished
+
+console.newTab=View step as plain text

src/test/java/io/jenkins/plugins/pipelinegraphview/playwright/PipelineConsole.java

@@ -70,8 +70,9 @@ public void stepContainsText(String stepName, String textToFind) {
         Locator stepLogs = stepContainer.getByRole(AriaRole.LOG);
         assertThat(stepLogs).containsText(textToFind);
 
-        try (Page plainText = page.waitForPopup(stepContainer.locator("a[href*='log?nodeId=']")::click)) {
-            plainText.waitForLoadState();
+        Locator plainTextLogsLink = stepContainer.getByRole(
+                AriaRole.LINK, new Locator.GetByRoleOptions().setName("View step as plain text"));
+        try (Page plainText = page.context().waitForPage(plainTextLogsLink::click)) {
             assertThat(plainText.locator("body")).containsText(textToFind);
         }
     }