Simplify PipelineNodeUtil#isStage to not include nodes with LabelActions

stuartrowe · stuartrowe · commit 603e1cf77fcf · 2025-02-06T12:48:58.000-08:00
diff --git a/src/main/java/io/jenkins/plugins/pipelinegraphview/utils/PipelineNodeUtil.java b/src/main/java/io/jenkins/plugins/pipelinegraphview/utils/PipelineNodeUtil.java
@@ -48,10 +48,7 @@ public static String getDisplayName(@NonNull FlowNode node) {
     }
 
     public static boolean isStage(FlowNode node) {
-        return node != null
-                && ((node.getAction(StageAction.class) != null)
-                        || (node.getAction(LabelAction.class) != null
-                                && node.getAction(ThreadNameAction.class) == null));
+        return node != null && (node.getAction(StageAction.class) != null);
     }
 
     public static boolean isSyntheticStage(@Nullable FlowNode node) {

Original file line number	Diff line number	Diff line change
`@@ -48,10 +48,7 @@ public static String getDisplayName(@NonNull FlowNode node) {`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`public static boolean isStage(FlowNode node) {`
`51`		`- return node != null`
`52`		`- && ((node.getAction(StageAction.class) != null)`
`53`		`- \|\| (node.getAction(LabelAction.class) != null`
`54`		`- && node.getAction(ThreadNameAction.class) == null));`
	`51`	`+ return node != null && (node.getAction(StageAction.class) != null);`
`55`	`52`	`}`
`56`	`53`
`57`	`54`	`public static boolean isSyntheticStage(@Nullable FlowNode node) {`