Rewrite rebuild actions using javascript java injection (#580)

Author: panicking

src/main/java/io/jenkins/plugins/pipelinegraphview/utils/AbstractPipelineViewAction.java

@@ -4,20 +4,24 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import hudson.model.Action;
 import hudson.model.BallColor;
-import hudson.model.ParametersAction;
-import hudson.model.ParametersDefinitionProperty;
+import hudson.model.Item;
+import hudson.model.Queue;
 import hudson.security.Permission;
 import hudson.util.HttpResponses;
+import java.io.IOException;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.TimeoutException;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import net.sf.json.JSONObject;
 import org.jenkins.ui.icon.IconSpec;
+import org.jenkinsci.plugins.workflow.cps.replay.ReplayAction;
 import org.jenkinsci.plugins.workflow.job.WorkflowRun;
 import org.kohsuke.stapler.HttpResponse;
 import org.kohsuke.stapler.StaplerRequest2;
 import org.kohsuke.stapler.WebMethod;
+import org.kohsuke.stapler.bind.JavaScriptMethod;
+import org.kohsuke.stapler.interceptor.RequirePOST;
 
 public abstract class AbstractPipelineViewAction implements Action, IconSpec {
     private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
@@ -47,14 +51,24 @@ public String getBuildDisplayName() {
         return run.getDisplayName();
     }
 
-    public boolean isParameterized() {
-        ParametersAction paramAction = run.getAction(ParametersAction.class);
-        if (paramAction != null && !paramAction.getAllParameters().isEmpty()) {
+    /**
+     * Handles the rebuild request using ReplayAction feature
+     */
+    @RequirePOST
+    @JavaScriptMethod
+    public boolean doRebuild() throws IOException, ExecutionException {
+        if (run != null) {
+            run.checkAnyPermission(Item.BUILD);
+            ReplayAction replayAction = run.getAction(ReplayAction.class);
+            Queue.Item item =
+                    replayAction.run2(replayAction.getOriginalScript(), replayAction.getOriginalLoadedScripts());
+
+            if (item == null) {
+                return false;
+            }
             return true;
         }
-
-        ParametersDefinitionProperty property = run.getParent().getProperty(ParametersDefinitionProperty.class);
-        return property != null && !property.getParameterDefinitions().isEmpty();
+        return false;
     }
 
     public String getFullBuildDisplayName() {

src/main/resources/io/jenkins/plugins/pipelinegraphview/PipelineGraphViewAction/index.jelly

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 
 <?jelly escape-by-default='true'?>
-<j:jelly xmlns:j="jelly:core" xmlns:l="/lib/layout" xmlns:p="/lib/pipeline-graph-view">
+<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:l="/lib/layout" xmlns:p="/lib/pipeline-graph-view">
   <l:layout title="${%Graph} [${it.fullBuildDisplayName}]" type="one-column">
     <l:main-panel>
       <div class="jenkins-app-bar">
@@ -26,8 +26,11 @@
         <div class="jenkins-app-bar__controls">
           <j:if test="${it.buildable}">
             <l:hasPermission permission="${it.permission}">
-              <button id="pgv-rebuild" data-success-message="${%Build scheduled}" data-build-path="../../build"
-                      data-parameterized="${it.parameterized}" class="jenkins-button jenkins-!-build-color">
+              <j:set var="proxyId" value="${h.generateId()}" />
+              <st:bind value="${it}" var="rebuildAction${proxyId}"/>
+              <button id="pgv-rebuild" data-success-message="${%Build scheduled}"
+                      data-proxy-name="rebuildAction${proxyId}"
+                      class="jenkins-button jenkins-!-build-color">
                 <l:icon src="symbol-play-outline plugin-ionicons-api"/>
                 ${%Rebuild}
               </button>

src/main/resources/io/jenkins/plugins/pipelinegraphview/consoleview/PipelineConsoleViewAction/index.jelly

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 
 <?jelly escape-by-default='true'?>
-<j:jelly xmlns:j="jelly:core" xmlns:l="/lib/layout" xmlns:dd="/lib/layout/dropdowns">
+<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:l="/lib/layout" xmlns:dd="/lib/layout/dropdowns">
     <l:layout title="${%Build log} [${it.buildDisplayName}]" type="one-column">
         <l:main-panel>
             <div class="jenkins-app-bar">
@@ -24,8 +24,10 @@
                 <div class="jenkins-app-bar__controls">
                     <j:if test="${it.buildable}">
                         <l:hasPermission permission="${it.permission}">
+                            <j:set var="proxyId" value="${h.generateId()}" />
+                            <st:bind value="${it}" var="rebuildAction${proxyId}"/>
                             <button id="pgv-rebuild" data-success-message="${%Build scheduled}"
-                                    data-build-path="../../build" data-parameterized="${it.parameterized}"
+                                    data-proxy-name="rebuildAction${proxyId}"
                                     class="jenkins-button jenkins-!-build-color">
                                 <l:icon src="symbol-play-outline plugin-ionicons-api"/>
                                 ${%Rebuild}

src/main/resources/io/jenkins/plugins/pipelinegraphview/multipipelinegraphview/MultiPipelineGraphViewAction/index.jelly

@@ -7,8 +7,11 @@
       <l:app-bar title="${%Build} ${it.jobDisplayName}">
         <j:if test="${it.buildable}">
           <l:hasPermission permission="${it.permission}">
-            <button id="pgv-rebuild" data-success-message="${%Build scheduled}" data-build-path="../build"
-                    data-parameterized="${it.parameterized}" class="jenkins-button jenkins-!-build-color">
+            <j:set var="proxyId" value="${h.generateId()}" />
+            <st:bind value="${it}" var="rebuildAction${proxyId}"/>
+            <button id="pgv-rebuild" data-success-message="${%Build scheduled}"
+                    data-proxy-name="rebuildAction${proxyId}"
+                    class="jenkins-button jenkins-!-build-color">
               <l:icon src="symbol-play-outline plugin-ionicons-api"/>
               ${%Build}
             </button>

src/main/webapp/js/build.js

@@ -3,21 +3,12 @@ const rebuildButton = document.getElementById('pgv-rebuild');
 if (rebuildButton) {
   rebuildButton.addEventListener('click', event => {
     event.preventDefault();
-    const buildUrl = `${rebuildButton.dataset.buildPath}?delay=0sec`
-    if (rebuildButton.dataset.parameterized === 'true') {
-      window.location.href = buildUrl
-    } else {
-      fetch(buildUrl, {
-        method: 'post',
-        headers: crumb.wrap({})
-      })
-        .then(res => {
-          if (!res.ok) {
-            console.error('Build failed', res);
-          } else {
-            window.hoverNotification(rebuildButton.dataset.successMessage, rebuildButton);
-          }
-        })
-    }
+    const rebuildAction = window[`${rebuildButton.dataset.proxyName}`];
+    rebuildAction.doRebuild(function (success) {
+      const result = success.responseJSON;
+      if (result) {
+        window.hoverNotification(rebuildButton.dataset.successMessage, rebuildButton);
+      }
+    });
   })
 }

src/test/java/io/jenkins/plugins/pipelinegraphview/PipelineGraphViewRebuildTest.java

@@ -41,9 +41,7 @@ public void rebuildButtonRedirectsForParameterizedJob() throws Exception {
 
             HtmlPage page = webClient.getPage(run, new PipelineGraphViewAction(run).getUrlName());
             HtmlPage newPage = page.getElementById("pgv-rebuild").click();
-            assertEquals(
-                    j.getURL() + run.getParent().getUrl() + "build?delay=0sec",
-                    newPage.getBaseURL().toExternalForm());
+            assertEquals(page.getBaseURL(), newPage.getBaseURL());
         }
     }
 }