Skip to content

Commit 999948f

Browse files
authored
Stay in Pipeline Overview page when navigating to upstream build (#829)
1 parent 102a888 commit 999948f

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/main/java/io/jenkins/plugins/pipelinegraphview/cards/items/UpstreamCauseRunDetailsItem.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
import hudson.model.Cause;
44
import hudson.model.CauseAction;
55
import io.jenkins.plugins.pipelinegraphview.Messages;
6+
import io.jenkins.plugins.pipelinegraphview.PipelineGraphDisplayURLProvider;
67
import io.jenkins.plugins.pipelinegraphview.cards.RunDetailsItem;
78
import io.jenkins.plugins.pipelinegraphview.cards.RunDetailsItem.Icon.Ionicon;
89
import io.jenkins.plugins.pipelinegraphview.cards.RunDetailsItem.ItemContent;
910
import java.util.List;
1011
import java.util.Objects;
1112
import java.util.Optional;
12-
import org.jenkinsci.plugins.displayurlapi.DisplayURLProvider;
1313
import org.jenkinsci.plugins.workflow.job.WorkflowRun;
1414

1515
public class UpstreamCauseRunDetailsItem {
@@ -26,7 +26,7 @@ public static Optional<RunDetailsItem> get(WorkflowRun run) {
2626
.map(Cause.UpstreamCause::getUpstreamRun)
2727
.filter(Objects::nonNull)
2828
.map(upstreamRun -> ItemContent.of(
29-
DisplayURLProvider.getDefault().getRunURL(upstreamRun),
29+
new PipelineGraphDisplayURLProvider().getRunURL(upstreamRun),
3030
Messages.cause_upstream(upstreamRun.getDisplayName())))
3131
.<RunDetailsItem>map(
3232
content -> new RunDetailsItem.RunDetail(new Ionicon("play-circle-outline"), content))

src/test/java/io/jenkins/plugins/pipelinegraphview/cards/items/UpstreamCauseRunDetailsItemTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ void get() {
6161
RunDetailsItem.RunDetail userDetails = (RunDetailsItem.RunDetail) detailsItem.get();
6262

6363
assertEquals(
64-
new RunDetailsItem.ItemContent.LinkContent(baseUrl + run.getUrl(), Messages.cause_upstream("#1")),
64+
new RunDetailsItem.ItemContent.LinkContent(
65+
baseUrl + run.getUrl() + "pipeline-overview", Messages.cause_upstream("#1")),
6566
userDetails.content());
6667
assertEquals("symbol-play-circle-outline plugin-ionicons-api", userDetails.icon());
6768
}

0 commit comments

Comments
 (0)