Fix NPE when no cause can be identified (#746)

Author: lewisbirks

src/main/java/io/jenkins/plugins/pipelinegraphview/cards/items/UpstreamCauseRunDetailsItem.java

@@ -16,6 +16,9 @@ public class UpstreamCauseRunDetailsItem {
 
     public static Optional<RunDetailsItem> get(WorkflowRun run) {
         CauseAction causeAction = run.getAction(CauseAction.class);
+        if (causeAction == null) {
+            return Optional.empty();
+        }
         List<Cause> causes = causeAction.getCauses();
         return causes.stream()
                 .filter(cause -> cause instanceof Cause.UpstreamCause)

src/main/java/io/jenkins/plugins/pipelinegraphview/cards/items/UserIdCauseRunDetailsItem.java

@@ -17,6 +17,9 @@ public class UserIdCauseRunDetailsItem {
 
     public static Optional<RunDetailsItem> get(WorkflowRun run) {
         CauseAction causeAction = run.getAction(CauseAction.class);
+        if (causeAction == null) {
+            return Optional.empty();
+        }
         List<Cause> causes = causeAction.getCauses();
         return causes.stream()
                 .filter(cause -> cause instanceof Cause.UserIdCause)

src/test/java/io/jenkins/plugins/pipelinegraphview/cards/items/UpstreamCauseRunDetailsItemTest.java

@@ -0,0 +1,68 @@
+package io.jenkins.plugins.pipelinegraphview.cards.items;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import hudson.model.Cause;
+import hudson.model.CauseAction;
+import hudson.model.Result;
+import io.jenkins.plugins.pipelinegraphview.Messages;
+import io.jenkins.plugins.pipelinegraphview.cards.RunDetailsItem;
+import io.jenkins.plugins.pipelinegraphview.utils.TestUtils;
+import java.util.Optional;
+import org.jenkinsci.plugins.workflow.job.WorkflowRun;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.jvnet.hudson.test.JenkinsRule;
+import org.jvnet.hudson.test.junit.jupiter.WithJenkins;
+
+@WithJenkins
+class UpstreamCauseRunDetailsItemTest {
+
+    private static WorkflowRun run;
+    private static String baseUrl;
+
+    @BeforeAll
+    static void beforeAll(JenkinsRule j) throws Exception {
+        run = TestUtils.createAndRunJob(j, "simple", "singleStagePipeline.jenkinsfile", Result.SUCCESS);
+        baseUrl = j.getURL().toString();
+    }
+
+    @BeforeEach
+    void setUp() {
+        run.removeActions(CauseAction.class);
+    }
+
+    @Test
+    void get_noActionsOfType() {
+        Optional<RunDetailsItem> detailsItem = UpstreamCauseRunDetailsItem.get(run);
+
+        assertTrue(detailsItem.isEmpty());
+    }
+
+    @Test
+    void get_noUpstreamCause() {
+        run.addAction(new CauseAction(new Cause.UserIdCause("User Id")));
+
+        Optional<RunDetailsItem> detailsItem = UpstreamCauseRunDetailsItem.get(run);
+
+        assertTrue(detailsItem.isEmpty());
+    }
+
+    @Test
+    void get() {
+        run.addAction(new CauseAction(new Cause.UpstreamCause(run)));
+
+        Optional<RunDetailsItem> detailsItem = UpstreamCauseRunDetailsItem.get(run);
+
+        assertTrue(detailsItem.isPresent());
+
+        RunDetailsItem.RunDetail userDetails = (RunDetailsItem.RunDetail) detailsItem.get();
+
+        assertEquals(
+                new RunDetailsItem.ItemContent.LinkContent(baseUrl + run.getUrl(), Messages.cause_upstream("#1")),
+                userDetails.content());
+        assertEquals("symbol-play-circle-outline plugin-ionicons-api", userDetails.icon());
+    }
+}

src/test/java/io/jenkins/plugins/pipelinegraphview/cards/items/UserIdCauseRunDetailsItemTest.java

@@ -0,0 +1,85 @@
+package io.jenkins.plugins.pipelinegraphview.cards.items;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import hudson.model.Cause;
+import hudson.model.CauseAction;
+import hudson.model.Result;
+import hudson.model.User;
+import io.jenkins.plugins.pipelinegraphview.Messages;
+import io.jenkins.plugins.pipelinegraphview.cards.RunDetailsItem;
+import io.jenkins.plugins.pipelinegraphview.utils.TestUtils;
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Optional;
+import org.jenkinsci.plugins.workflow.job.WorkflowRun;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.jvnet.hudson.test.JenkinsRule;
+import org.jvnet.hudson.test.junit.jupiter.WithJenkins;
+
+@WithJenkins
+class UserIdCauseRunDetailsItemTest {
+
+    private static WorkflowRun run;
+
+    @BeforeAll
+    static void beforeAll(JenkinsRule j) throws Exception {
+        run = TestUtils.createAndRunJob(j, "simple", "singleStagePipeline.jenkinsfile", Result.SUCCESS);
+    }
+
+    @BeforeEach
+    void setUp() {
+        run.removeActions(CauseAction.class);
+        User.getAll().forEach(user -> {
+            try {
+                user.delete();
+            } catch (IOException e) {
+                throw new RuntimeException(e);
+            }
+        });
+    }
+
+    @Test
+    void get_noActionsOfType() {
+        Optional<RunDetailsItem> detailsItem = UserIdCauseRunDetailsItem.get(run);
+
+        assertTrue(detailsItem.isEmpty());
+    }
+
+    @Test
+    void get_noUserIdCause() {
+        run.addAction(new CauseAction(new Cause.UpstreamCause(run)));
+
+        Optional<RunDetailsItem> detailsItem = UserIdCauseRunDetailsItem.get(run);
+
+        assertTrue(detailsItem.isEmpty());
+    }
+
+    @Test
+    void get_userNotFound() {
+        run.addAction(new CauseAction(new Cause.UserIdCause("User Id")));
+
+        Optional<RunDetailsItem> detailsItem = UserIdCauseRunDetailsItem.get(run);
+
+        assertTrue(detailsItem.isEmpty());
+    }
+
+    @Test
+    void get() {
+        run.addAction(new CauseAction(new Cause.UserIdCause("User Id")));
+        User.get("User Id", true, new HashMap<>());
+
+        Optional<RunDetailsItem> detailsItem = UserIdCauseRunDetailsItem.get(run);
+
+        assertTrue(detailsItem.isPresent());
+
+        RunDetailsItem.RunDetail userDetails = (RunDetailsItem.RunDetail) detailsItem.get();
+
+        assertEquals(
+                new RunDetailsItem.ItemContent.PlainContent(Messages.cause_user("User Id")), userDetails.content());
+        assertEquals("symbol-person-outline plugin-ionicons-api", userDetails.icon());
+    }
+}