Use nested layout by default (#1311)

Author: das7pad

src/main/frontend/pipeline-graph-view/pipeline-graph/main/PipelineGraphModel.tsx

@@ -175,7 +175,7 @@ export interface PositionedGraph {
   measuredHeight: number;
 }
 
-export function isFlagEnabled(flag: string) {
+export function isFlagEnabled(flag: string, defaultValue: boolean = false) {
   const isEnabled = (v: string | null) =>
     ["yes", "1", "true", "enabled"].includes(v?.toLowerCase() ?? "");
 
@@ -185,11 +185,12 @@ export function isFlagEnabled(flag: string) {
   } catch {}
   try {
     // LocalStorage access can throw, gracefully access the key.
-    return isEnabled(window.localStorage.getItem(flag));
+    const v = window.localStorage.getItem(flag);
+    if (v !== null) return isEnabled(v);
   } catch {}
-  return false;
+  return defaultValue;
 }
 
-export const nestedLayout = () => isFlagEnabled("nestedLayout");
+export const nestedLayout = () => isFlagEnabled("nestedLayout", true);
 // Optionally turn on debugging for the graph. Once the nested layout is stable, we could use a constant to let tree-shaking remove debug code in production bundles.
 export const debugPipelineGraph = () => isFlagEnabled("debugPipelineGraph");

src/test/java/io/jenkins/plugins/pipelinegraphview/PipelineGraphViewNestedTest.java

@@ -13,7 +13,6 @@
 import io.jenkins.plugins.pipelinegraphview.utils.TestUtils;
 import org.jenkinsci.plugins.workflow.job.WorkflowRun;
 import org.jenkinsci.plugins.workflow.test.steps.SemaphoreStep;
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.jvnet.hudson.test.Issue;
 
@@ -24,11 +23,6 @@ class PipelineGraphViewNestedTest {
     // mvn exec:java -e -D exec.mainClass="com.microsoft.playwright.CLI" -Dexec.classpathScope=test -Dexec.args="codegen
     // http://localhost:8080/jenkins
 
-    @BeforeEach
-    void setUp(Page p) {
-        p.context().addInitScript("window.localStorage.setItem('nestedLayout', 'true')");
-    }
-
     @Test
     void smokeTest(Page p, JenkinsConfiguredWithCodeRule j) throws Exception {
         String name = "Integration Tests";

src/test/java/io/jenkins/plugins/pipelinegraphview/PipelineGraphViewTest.java

@@ -13,6 +13,7 @@
 import io.jenkins.plugins.pipelinegraphview.utils.TestUtils;
 import org.jenkinsci.plugins.workflow.job.WorkflowRun;
 import org.jenkinsci.plugins.workflow.test.steps.SemaphoreStep;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.jvnet.hudson.test.Issue;
 
@@ -23,6 +24,11 @@ class PipelineGraphViewTest {
     // mvn exec:java -e -D exec.mainClass="com.microsoft.playwright.CLI" -Dexec.classpathScope=test -Dexec.args="codegen
     // http://localhost:8080/jenkins
 
+    @BeforeEach
+    void setUp(Page p) {
+        p.context().addInitScript("window.localStorage.setItem('nestedLayout', 'false')");
+    }
+
     @Test
     void smokeTest(Page p, JenkinsConfiguredWithCodeRule j) throws Exception {
         String name = "Integration Tests";