[JENKINS-69757] Improve priority sorter plugin automated test coverage

[jenkins-infra-bot]

Increase automated test coverage

Automated test coverage of the priority sorter plugin is low. Improve the automated test coverage by submitting pull requests with new automated tests.

Review current coverage

Review the current test coverage with the commands:

Linux

$ mvn -P enable-jacoco clean install jacoco:report
$ xdg-open target/site/jacoco/index.html

Windows

C:\Users\Yourname > mvn -P enable-jacoco clean install jacoco:report
C:\Users\Yourname > start target\site\jacoco\index.html

More information is in the "code coverage" section of the contributing guide.

Create a new test for a class that is not well covered

Most integrated development environments have tools that will create a test stub that is a good beginning. Apache Netbeans has "Create / Update tests" . JetBrains IntelliJ has "Create tests". Visual Studio Code has the "Extension Pack for Java".

Use the IDE or your own coding to create a test for one of the classes that is not well covered by tests.

Keep the test small so that the pull request is easy to review.

---

Originally reported by markewaite, imported from: Improve priority sorter plugin automated test coverage

• status: In Review
• priority: Minor
• component(s): prioritysorter-plugin
• label(s): newbie-friendly
• resolution: Unresolved
• votes: 0
• watchers: 5
• imported: 20251211-071809

Raw content of original issue

Increase automated test coverage

Automated test coverage of the priority sorter plugin is low.  Improve the automated test coverage by submitting pull requests with new automated tests.

Review current coverage

Review the current test coverage with the commands:

Linux


$ mvn -P enable-jacoco clean install jacoco:report
$ xdg-open target/site/jacoco/index.html


Windows

C:\Users\Yourname > mvn -P enable-jacoco clean install jacoco:report
C:\Users\Yourname > start target\site\jacoco\index.html


More information is in the "code coverage" section of the contributing guide.
Create a new test for a class that is not well covered
Most integrated development environments have tools that will create a test stub that is a good beginning.  Apache Netbeans has "Create / Update tests" .  JetBrains IntelliJ has "Create tests". Visual Studio Code has the "Extension Pack for Java".
Use the IDE or your own coding to create a test for one of the classes that is not well covered by tests.
Keep the test small so that the pull request is easy to review.

1 attachment

• current-test-coverage.png

  

[jenkins-infra-bot]

• Remote links associated with this issue:

  • PR-447 - improve test coverage
  • PR-448 - improve test coverage
  • PR-466 - improve test coverage

[jenkins-infra-bot]

udit_damare:

• Original comment link
• Raw content of original comment:

  Hello markewaite, I would like to work on this new feature task
  Can you assign this to me?
  
   
  

Hello markewaite, I would like to work on this new feature task
Can you assign this to me?

 

[jenkins-infra-bot]

markewaite:

• Original comment link
• Raw content of original comment:

  udit_damare you're welcome to work on it.  I would love to have the contributions.
  
  I don't assign issues to individuals in general because in far too many cases the individual says they are interested then they don't contribute a pull request to actually work on the issue.  Your comment "I would like to work on this task" is already enough that others who might be interested in the task will know that they need to coordinate efforts here.  If we have multiple people working on the issue, we'll coordinate by dividing the classes to test or by some other partitioning of the effort.  That has not been a problem yet.
  

udit_damare you're welcome to work on it. I would love to have the contributions.

I don't assign issues to individuals in general because in far too many cases the individual says they are interested then they don't contribute a pull request to actually work on the issue. Your comment "I would like to work on this task" is already enough that others who might be interested in the task will know that they need to coordinate efforts here. If we have multiple people working on the issue, we'll coordinate by dividing the classes to test or by some other partitioning of the effort. That has not been a problem yet.

[jenkins-infra-bot]

sunnylllllllll:

• Original comment link
• Raw content of original comment:

  I have proposed the PR.
  
  JENKINS-69757 Improve priority sorter plugin automated test coverage #259
  

I have proposed the PR.

#259

[jenkins-infra-bot]

yash_21:

• Original comment link
• Raw content of original comment:

  Hey markewaite does this plugin require work maybe I can help write more tests to increase the coverage
  

Hey markewaite does this plugin require work maybe I can help write more tests to increase the coverage

[jenkins-infra-bot]

markewaite:

• Original comment link
• Raw content of original comment:

  does this plugin require work?
  
  yash_21 thanks for asking.  Yes, it does need more automated tests..  The current test coverage is reported on ci.jenkins like this:
  
    
  
  I generally won't close a test coverage issue until the line coverage is at least 80% and the branch coverage is at least 80%..
  
  Writing automated tests is a great way to practice using a Java debugger to better understand code.  That benefits you.  The additional tests help us keep the plugin in good condition for future changes.  That benefits the Jenkins project.
  

does this plugin require work?

yash_21 thanks for asking. Yes, it does need more automated tests.. The current test coverage is reported on ci.jenkins like this:

I generally won't close a test coverage issue until the line coverage is at least 80% and the branch coverage is at least 80%..

Writing automated tests is a great way to practice using a Java debugger to better understand code. That benefits you. The additional tests help us keep the plugin in good condition for future changes. That benefits the Jenkins project.

[jenkins-infra-bot]

yash_21:

• Original comment link
• Raw content of original comment:

  Hey markewaite would you like the same tests-type as used in the nodelabelparameter plugin i.e. use of Jenkins Rule or would you also like Mock objects to be used in these tests for these classes?
  
    
  

Hey markewaite would you like the same tests-type as used in the nodelabelparameter plugin i.e. use of Jenkins Rule or would you also like Mock objects to be used in these tests for these classes?

  

[jenkins-infra-bot]

markewaite:

• Original comment link
• Raw content of original comment:

  I prefer JenkinsRule as much as can reasonably be done.
  

I prefer JenkinsRule as much as can reasonably be done.

[jenkins-infra-bot]

yash_21:

• Original comment link
• Raw content of original comment:

  I have made a PR for  this: Add test for JobInclusionFolderProperty class #416
  

I have made a PR for  this: #416

[jenkins-infra-bot]

markewaite:

• Original comment link
• Raw content of original comment:

  I've linked to the 3 pull requests that will close this issue.  Thanks to the contributors that have submitted the additional tests.
  

I've linked to the 3 pull requests that will close this issue. Thanks to the contributors that have submitted the additional tests.