Skip to content

Commit 316c049

Browse files
committed
More pom.xml clean-up
+ JavaDoc cleanup
1 parent 8c40478 commit 316c049

File tree

2 files changed

+20
-50
lines changed

2 files changed

+20
-50
lines changed

pom.xml

Lines changed: 9 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
1+
<project xmlns="http://maven.apache.org/POM/4.0.0"
2+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
23
<modelVersion>4.0.0</modelVersion>
34
<url>https://wiki.jenkins.io/display/JENKINS/Rebuild+Plugin</url>
45
<parent>
@@ -59,44 +60,12 @@
5960
<plugins>
6061
<plugin>
6162
<groupId>org.apache.maven.plugins</groupId>
62-
<artifactId>maven-compiler-plugin</artifactId>
63-
<configuration>
64-
<source>1.6</source>
65-
<target>1.6</target>
66-
</configuration>
67-
</plugin>
68-
<plugin>
6963
<artifactId>maven-release-plugin</artifactId>
70-
<version>2.5.1</version>
71-
<dependencies>
72-
<dependency>
73-
<groupId>org.apache.maven.scm</groupId>
74-
<artifactId>maven-scm-provider-gitexe</artifactId>
75-
<version>1.9.2</version>
76-
</dependency>
77-
</dependencies>
7864
<configuration>
79-
<goals>-DskipTests deploy</goals>
65+
<tagNameFormat>v@{project.version}</tagNameFormat>
8066
</configuration>
8167
</plugin>
82-
<plugin>
83-
<artifactId>maven-jar-plugin</artifactId>
84-
<executions>
85-
<execution>
86-
<goals>
87-
<goal>test-jar</goal>
88-
</goals>
89-
</execution>
90-
</executions>
91-
</plugin>
9268
</plugins>
93-
<extensions>
94-
<extension>
95-
<groupId>org.jvnet.wagon-svn</groupId>
96-
<artifactId>wagon-svn</artifactId>
97-
<version>1.9</version>
98-
</extension>
99-
</extensions>
10069
</build>
10170
<distributionManagement>
10271
<repository>
@@ -140,13 +109,13 @@
140109
<dependency>
141110
<groupId>org.jenkins-ci.plugins</groupId>
142111
<artifactId>matrix-project</artifactId>
143-
<version>1.12</version>
112+
<version>1.18</version>
144113
</dependency>
145114
</dependencies>
146115
<scm>
147-
<connection>scm:git:git://github.com/jenkinsci/${project.artifactId}-plugin.git</connection>
148-
<developerConnection>scm:git:git@github.com:jenkinsci/${project.artifactId}-plugin.git</developerConnection>
149-
<url>https://github.com/jenkinsci/${project.artifactId}-plugin</url>
150-
<tag>HEAD</tag>
151-
</scm>
116+
<connection>scm:git:https://github.com/jenkinsci/rebuild-plugin</connection>
117+
<developerConnection>scm:git:https://github.com/jenkinsci/rebuild-plugin</developerConnection>
118+
<url>https://github.com/jenkinsci/rebuild-plugin</url>
119+
<tag>HEAD</tag>
120+
</scm>
152121
</project>

src/main/java/com/sonyericsson/rebuild/RebuildParameterProvider.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
/*
22
* The MIT License
3-
*
3+
*
44
* Copyright (c) 2013 IKEDA Yasuyuki
5-
*
5+
*
66
* Permission is hereby granted, free of charge, to any person obtaining a copy
77
* of this software and associated documentation files (the "Software"), to deal
88
* in the Software without restriction, including without limitation the rights
99
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
1010
* copies of the Software, and to permit persons to whom the Software is
1111
* furnished to do so, subject to the following conditions:
12-
*
12+
*
1313
* The above copyright notice and this permission notice shall be included in
1414
* all copies or substantial portions of the Software.
15-
*
15+
*
1616
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
1717
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
1818
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
@@ -32,7 +32,7 @@
3232

3333
/**
3434
* Extension point to provide views to show parameters in rebuild page.
35-
*
35+
*
3636
* If you want your custom {@link ParameterValue} to work with rebuild plugin,
3737
* do as followings:
3838
* <ol>
@@ -47,7 +47,8 @@
4747
* Don't forget to return <code>null</code> for parameter values
4848
* other than your custom {@link ParameterValue}.
4949
* There are two recommended ways to set values to {@link RebuildParameterPage}:
50-
* <table summary="Recommended ways to set values">
50+
* <table>
51+
<caption>Recommended way to set values</caption>
5152
* <tr>
5253
* <th>&nbsp;</th>
5354
* <th>Recommended 1</th>
@@ -72,17 +73,17 @@ public abstract class RebuildParameterProvider implements ExtensionPoint {
7273
// If defined as an interface, developers might carelessly apply this
7374
// to mandatory class in their plugin and their plugins get not to work
7475
// without rebuild plugin.
75-
76+
7677
/**
7778
* Provide a view for specified {@link ParameterValue}.
78-
*
79+
*
7980
* Return null if cannot handle specified {@link ParameterValue}.
80-
*
81+
*
8182
* @param value a value to be shown in a rebuild page.
8283
* @return page for the parameter value. null for parameter values cannot be handled.
8384
*/
8485
public abstract RebuildParameterPage getRebuildPage(ParameterValue value);
85-
86+
8687
/**
8788
* @return all {@link RebuildParameterProvider} registered to Jenkins.
8889
*/

0 commit comments

Comments
 (0)