Skip to content

Commit 1b5195d

Browse files
committed
Removing references to SCM2 also from docs #358 (review)
1 parent a3ac02d commit 1b5195d

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

docs/implementation.adoc

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1466,7 +1466,6 @@ Auto-registration of webhooks is performed in different methods depending on the
14661466

14671467
* `SCMNavigator.afterSave(_owner_)`
14681468
* `SCMSource.afterSave()`
1469-
* `SCM2.afterSave(_job_)`
14701469

14711470
In the above methods you need to register the webhook url using your SCM Provider API to which Jenkins will listen for events.
14721471

@@ -1483,17 +1482,6 @@ public String getHookUrl() {
14831482
}
14841483
----
14851484

1486-
[NOTE]
1487-
====
1488-
Existing implementations of the `hudson.scm.SCM` API have traditionally extended `hudson.triggers.Trigger` in order to integrate capture the requirement for setting up a webhook from the `Trigger.start(_job_,_newInstance_)` method.
1489-
1490-
This leads to a proliferation of triggers for multiple source control systems and consequently confuses users and leads to a bad user experience.
1491-
1492-
Switching those implementations to use `SCM2.afterSave(_job_,_scm_)` will result in a simpler user interface of just enabling _Poll SCM_ and managing the hooks through _Ignore post-commit hooks_.
1493-
1494-
Additionally, unless a source control system can guarantee delivery of events, in order to ensure that events are not lost, users will need to configure _Poll SCM_ in any case (even if only with the schedule of `@yearly`!)
1495-
====
1496-
14971485
[TIP]
14981486
====
14991487
If you are implementing auto-registration of webhooks, keep a local database of what hooks have been attempted to be registered.

0 commit comments

Comments
 (0)