Remove injection

The `GitScriptlerRepository` and `GitScriptlerRepositorySSHAccess`
classes used injection to receive objects of the given type. Switch from
injection to dynamic lookup using `ExtensionList`.

Author: mtughan

src/main/java/org/jenkinsci/plugins/scriptler/git/GitScriptlerRepository.java

@@ -6,7 +6,6 @@
 import hudson.Extension;
 import hudson.ExtensionList;
 import hudson.model.RootAction;
-import jakarta.inject.Inject;
 import java.io.IOException;
 import java.net.MalformedURLException;
 import java.net.URL;
@@ -34,6 +33,8 @@
 import org.jenkinsci.plugins.scriptler.ScriptlerPermissions;
 import org.jenkinsci.plugins.scriptler.SyncUtil;
 import org.jenkinsci.plugins.scriptler.config.ScriptlerConfiguration;
+import org.kohsuke.accmod.Restricted;
+import org.kohsuke.accmod.restrictions.NoExternalUse;
 
 /**
  * Exposes Git repository at <code>/scriptler.git</code>
@@ -45,9 +46,6 @@
 public class GitScriptlerRepository extends FileBackedHttpGitRepository implements RootAction {
     private static final Logger LOGGER = Logger.getLogger(GitScriptlerRepository.class.getName());
 
-    @Inject
-    public SSHD sshd;
-
     private static final int LOG_MAX_COMMITS = 20;
     static final String REPOID = "scriptler.git";
 
@@ -80,9 +78,14 @@ public String getHttpCloneUrl() {
         return Jenkins.get().getRootUrl() + REPOID;
     }
 
+    @Restricted(NoExternalUse.class)
+    public int getSshdPort() {
+        return SSHD.get().getActualPort();
+    }
+
     public String getSshCloneUrl() throws MalformedURLException {
         String hostname = new URL(Objects.requireNonNull(Jenkins.get().getRootUrl())).getHost();
-        int port = sshd.getActualPort();
+        int port = getSshdPort();
         return "ssh://" + hostname + ":" + port + "/" + REPOID;
     }
 

src/main/java/org/jenkinsci/plugins/scriptler/git/GitScriptlerRepositorySSHAccess.java

@@ -4,7 +4,7 @@
 package org.jenkinsci.plugins.scriptler.git;
 
 import hudson.Extension;
-import jakarta.inject.Inject;
+import hudson.ExtensionList;
 import java.io.IOException;
 import org.eclipse.jgit.transport.ReceivePack;
 import org.eclipse.jgit.transport.UploadPack;
@@ -19,15 +19,15 @@
 @Extension
 public class GitScriptlerRepositorySSHAccess extends RepositoryResolver {
 
-    @Inject
-    GitScriptlerRepository repo;
-
     /**
      * @see org.jenkinsci.plugins.gitserver.RepositoryResolver#createReceivePack(java.lang.String)
      */
     @Override
     public ReceivePack createReceivePack(String fullRepositoryName) throws IOException {
-        if (isMine(fullRepositoryName)) return repo.createReceivePack(repo.openRepository());
+        if (isMine(fullRepositoryName)) {
+            GitScriptlerRepository repo = ExtensionList.lookupSingleton(GitScriptlerRepository.class);
+            return repo.createReceivePack(repo.openRepository());
+        }
         return null;
     }
 
@@ -36,7 +36,10 @@ public ReceivePack createReceivePack(String fullRepositoryName) throws IOExcepti
      */
     @Override
     public UploadPack createUploadPack(String fullRepositoryName) throws IOException {
-        if (isMine(fullRepositoryName)) return new UploadPack(repo.openRepository());
+        if (isMine(fullRepositoryName)) {
+            GitScriptlerRepository repo = ExtensionList.lookupSingleton(GitScriptlerRepository.class);
+            return new UploadPack(repo.openRepository());
+        }
         return null;
     }
 

src/main/resources/org/jenkinsci/plugins/scriptler/git/GitScriptlerRepository/index.jelly

@@ -7,7 +7,7 @@
             <p>${%blurb}</p>
             <pre>
 ${%git_clone_command(it.httpCloneUrl)}
-<j:if test="${it.sshd.actualPort > 0}">${%git_clone_command(it.sshCloneUrl)}</j:if>
+<j:if test="${it.sshdPort > 0}">${%git_clone_command(it.sshCloneUrl)}</j:if>
             </pre>
             <j:if test="${it.hasPushPermission()}">
                 <p>