JENKINS-70066: Fix null check of parameters

The `@DataBoundConstructor` for `ScriptlerBuilder` takes a list of
parameters for the given script. It was annotated as `@NotNull`, but
`Descriptor.bindJSON` could occasionally pass `null` for the parameters
list. Fix this by annotating the parameter as `@CheckForNull` and
performing the appropriate null checks.

(cherry picked from commit adce718)

Author: mtughan

src/main/java/org/jenkinsci/plugins/scriptler/builder/ScriptlerBuilder.java

@@ -77,16 +77,24 @@ public class ScriptlerBuilder extends Builder implements Serializable {
     /**
      * @deprecated as of 3.5; use {@link #ScriptlerBuilder(String, String, boolean, List)}
      */
-    @Deprecated
-    public ScriptlerBuilder(String builderId, String scriptId, boolean propagateParams, Parameter[] parameters) {
-        this(builderId, scriptId, propagateParams, Arrays.asList(Objects.requireNonNull(parameters)));
+    @Deprecated(since = "3.5")
+    public ScriptlerBuilder(
+            @CheckForNull String builderId,
+            @CheckForNull String scriptId,
+            boolean propagateParams,
+            @CheckForNull Parameter[] parameters) {
+        this(builderId, scriptId, propagateParams, parameters == null ? List.of() : List.of(parameters));
     }
 
     @DataBoundConstructor
-    public ScriptlerBuilder(String builderId, String scriptId, boolean propagateParams, @NonNull List<Parameter> parameters) {
+    public ScriptlerBuilder(
+            @CheckForNull String builderId,
+            @CheckForNull String scriptId,
+            boolean propagateParams,
+            @CheckForNull List<Parameter> parameters) {
         this.builderId = builderId;
         this.scriptId = scriptId;
-        this.parameters = new ArrayList<>(parameters);
+        this.parameters = parameters == null ? List.of() : List.copyOf(parameters);
         this.propagateParams = propagateParams;
     }
 
@@ -180,7 +188,7 @@ public Parameter[] getParameters() {
 
     @NonNull
     public List<Parameter> getParametersList() {
-        return Collections.unmodifiableList(parameters);
+        return parameters;
     }
 
     public String getBuilderId() {
@@ -227,8 +235,9 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
 
         try {
 
-            // expand the parameters before passing these to the execution, this is to allow any token macro to resolve parameter values
-            List<Parameter> expandedParams = new LinkedList<>();
+            // expand the parameters before passing these to the execution, this is to allow any token macro to resolve
+            // parameter values
+            List<Parameter> expandedParams = new ArrayList<>();
 
             if (propagateParams) {
                 final ParametersAction paramsAction = build.getAction(ParametersAction.class);
@@ -365,17 +374,16 @@ public ScriptlerBuilder newInstance(StaplerRequest req, JSONObject formData) {
             }
 
             if (builder == null) {
-                builder = new ScriptlerBuilder(builderId, null, false, Collections.emptyList());
+                builder = new ScriptlerBuilder(builderId, null, false, List.of());
             }
 
             return builder.recreateBuilderWithBuilderIdIfRequired();
         }
 
         public List<Script> getScripts() {
             // TODO currently only script for RUN_SCRIPT permissions are returned?
-            Set<Script> scripts = getConfig().getScripts();
             List<Script> scriptsForBuilder = new ArrayList<>();
-            for (Script script : scripts) {
+            for (Script script : getConfig().getScripts()) {
                 if (script.nonAdministerUsing) {
                     scriptsForBuilder.add(script);
                 }

src/main/java/org/jenkinsci/plugins/scriptler/config/Script.java

@@ -24,6 +24,7 @@
 package org.jenkinsci.plugins.scriptler.config;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
 import java.util.*;
 
@@ -118,6 +119,7 @@ public void setAvailable(boolean available) {
         this.available = available;
     }
 
+    @SuppressFBWarnings("PA_PUBLIC_PRIMITIVE_ATTRIBUTE")
     public void setScript(String script) {
         this.script = script;
     }

src/main/resources/META-INF/hudson.remoting.ClassFilter

@@ -0,0 +1,2 @@
+java.util.ImmutableCollections$ListN
+java.util.ImmutableCollections$List12