Skip to content

Commit 9247a31

Browse files
authored
Fix NPE in FileItem compatibility layer (#651)
1 parent 9283898 commit 9247a31

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

core/src/main/java/org/apache/commons/fileupload/FileItem.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import java.io.UnsupportedEncodingException;
2727
import java.nio.charset.Charset;
2828
import java.nio.file.Path;
29+
import java.util.Objects;
2930
import org.apache.commons.fileupload2.core.FileItemHeadersProvider;
3031

3132
/**
@@ -331,6 +332,7 @@ public org.apache.commons.fileupload2.core.FileItem write(Path file) throws IOEx
331332
}
332333

333334
static FileItem fromFileUpload2FileItem(org.apache.commons.fileupload2.core.FileItem from) {
335+
Objects.requireNonNull(from);
334336
return new FileItem() {
335337

336338
@Override

core/src/main/java/org/kohsuke/stapler/RequestImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1320,7 +1320,8 @@ public FileItem getFileItem2(String name) throws ServletException, IOException {
13201320
@Deprecated
13211321
@Override
13221322
public org.apache.commons.fileupload.FileItem getFileItem(String name) throws ServletException, IOException {
1323-
return org.apache.commons.fileupload.FileItem.fromFileUpload2FileItem(getFileItem2(name));
1323+
FileItem fileItem = getFileItem2(name);
1324+
return fileItem != null ? org.apache.commons.fileupload.FileItem.fromFileUpload2FileItem(fileItem) : null;
13241325
}
13251326

13261327
private static final Logger LOGGER = Logger.getLogger(RequestImpl.class.getName());

0 commit comments

Comments
 (0)