Remove long-deprecated handler count options (#294)

Author: basil

src/main/java/winstone/Launcher.java

@@ -85,13 +85,6 @@ public Launcher(Map<String, String> args) throws IOException {
             this.args = args;
             this.controlPort =Option.CONTROL_PORT.get(args);
 
-            if( Option.HANDLER_COUNT_MAX.get( args, -1 )!=-1){
-                Logger.log(Logger.WARNING, RESOURCES, Option.HANDLER_COUNT_MAX.name);
-            }
-            if( Option.HANDLER_COUNT_MAX_IDLE.get( args, -1 )!=-1){
-                Logger.log(Logger.WARNING, RESOURCES, Option.HANDLER_COUNT_MAX_IDLE.name);
-            }
-
             // Check for java home
             List<URL> jars = new ArrayList<>();
             String defaultJavaHome = System.getProperty("java.home");

src/main/java/winstone/cmdline/Option.java

@@ -80,25 +80,6 @@ public static List<Option<?>> all(Class<?> clazz) {
 
     public static final OBoolean USE_JMX=bool("useJmx",false);
 
-    /**
-     * @deprecated NOT USED
-     * How many requests do we handle concurrently?
-     *
-     * If the system gets really loaded, too many concurrent threads will create vicious cycles
-     * and make everyone slow (or worst case choke every request by OOME), so better to err
-     * on the conservative side (and have inbound connections wait in the queue)
-     */
-    @Deprecated
-    public static final OInt HANDLER_COUNT_MAX     =integer("handlerCountMax",-1);
-
-    /**
-     * @deprecated NOT USED
-     * Leave this number of request handler threads in the pool even when they are idle.
-     * Other threads are destroyed when they are idle to free up resources.
-     */
-    @Deprecated
-    public static final OInt HANDLER_COUNT_MAX_IDLE=integer("handlerCountMaxIdle",-1);
-
     public static final OInt QTP_MAXTHREADS=integer("qtpMaxThreadsCount",-1);
     public static final OInt JETTY_ACCEPTORS=integer("jettyAcceptorsCount",-1);
     public static final OInt JETTY_SELECTORS=integer("jettySelectorsCount",0);

src/main/resources/winstone/LocalStrings.properties

@@ -137,6 +137,3 @@ HttpsListener.KeyStoreNotFound=No SSL key store found at [#0]
 HttpsListener.ExcludeCiphers=Exclude Ciphers [#0]
 
 Http2ConnectorFactory.FailedStart.ALPN=Failed to start ALPN
-
-handlerCountMax=Parameter handlerCountMax is now deprecated
-handlerCountMaxIdle=Parameter handlerCountMaxIdle is now deprecated