[JENKINS-75487] limit number of "did you forget the def keyword" warnings to avoid OOM

[jenkins-infra-bot]

I've meanwhile experienced several pipelines that almost lead to crashing the controller after introducing the "def keyword" warning. When this warning is triggered in tightly looped groovy code, it easily increases the log size by hundreds of MB.

Would it be possible to only add that warning at most a fixed number of times (like 10.000) to avoid the log size getting out of control?

This is not meant as an excuse to not fix these pipelines. It's just that some teams basically had issues to even investigate the problem because of their huge logs now.

---

Originally reported by bananeweizen, imported from: limit number of "did you forget the def keyword" warnings to avoid OOM

• status: Open
• priority: Minor
• component(s): workflow-cps-plugin
• resolution: Unresolved
• votes: 0
• watchers: 3
• imported: 2025-12-07

Raw content of original issue

I've meanwhile experienced several pipelines that almost lead to crashing the controller after introducing the "def keyword" warning. When this warning is triggered in tightly looped groovy code, it easily increases the log size by hundreds of MB.

Would it be possible to only add that warning at most a fixed number of times (like 10.000) to avoid the log size getting out of control?

This is not meant as an excuse to not fix these pipelines. It's just that some teams basically had issues to even investigate the problem because of their huge logs now.

[jenkins-infra-bot]

wmoorby:

• Original comment link
• Raw content of original comment:

  Not sure if I should create a new issue for asking this question because it is related to this.
  
  Is it possible to not have this warning when using strongly typed variables like String myString = 'something', or Map<String, boolean> myBools = ['something': true], you get the idea.
  
  I prefer using this syntax as it makes it more clear what type a variable is, even though it's not necessarily required as you can use def and allow Groovy to infer the type.
  
  My understanding is that these still work in the same way as def, the only difference is if you try to set the variable to something that isn't the correct type, you get an error, like with List thisIsActuallyAMap = [:].
  I still prefer doing it this way for better readability and debugging, but obviously it causes the logs to be flooded with this newer warning.
  
  EDIT: Actually, it looks like my query relates to JENKINS-75361, but that ticket resulted in "no defect" and was a user issue.
  
  I also just had a look at my pipeline again and realised it's not erroring when using strong types, my bad for adding necessary noise to this, sorry!
  

Not sure if I should create a new issue for asking this question because it is related to this.

Is it possible to not have this warning when using strongly typed variables like String myString = 'something', or Map myBools = ['something': true], you get the idea.

I prefer using this syntax as it makes it more clear what type a variable is, even though it's not necessarily required as you can use def and allow Groovy to infer the type.

My understanding is that these still work in the same way as def, the only difference is if you try to set the variable to something that isn't the correct type, you get an error, like with List thisIsActuallyAMap = [:].
I still prefer doing it this way for better readability and debugging, but obviously it causes the logs to be flooded with this newer warning.

EDIT: Actually, it looks like my query relates to JENKINS-75361, but that ticket resulted in "no defect" and was a user issue.

I also just had a look at my pipeline again and realised it's not erroring when using strong types, my bad for adding necessary noise to this, sorry!