fix(skills): address PR #17 review - quote YAML values, clarify scope rules, refactor CSV validation

Author: breadoncee

docs/activation-model.md

@@ -72,7 +72,7 @@ The runtime decides how these actions map to a specific agent. This repository o
 ## Conflict Resolution
 
 1. Highest `priority` wins.
-2. If priorities tie, the rule with the narrower path scope wins.
+2. If priorities tie, the rule with the narrower path scope wins. A rule with no `paths-any` matcher is considered the widest possible scope (matches all paths).
 3. If rules still tie, prefer the lower `risk-level`.
 4. If there is still a tie, activate no new skill and surface an audit note.
 

scripts/init-skill.sh

@@ -181,16 +181,16 @@ mkdir -p "$SKILL_DIR"
     echo "argument-hint: \"$ARGUMENT_HINT\""
   fi
   if [[ -n "$CAPABILITIES" ]]; then
-    echo "capabilities: $CAPABILITIES"
+    echo "capabilities: \"$CAPABILITIES\""
   fi
   if [[ -n "$ACTIVATION_INTENTS" ]]; then
-    echo "activation-intents: $ACTIVATION_INTENTS"
+    echo "activation-intents: \"$ACTIVATION_INTENTS\""
   fi
   if [[ -n "$ACTIVATION_EVENTS" ]]; then
-    echo "activation-events: $ACTIVATION_EVENTS"
+    echo "activation-events: \"$ACTIVATION_EVENTS\""
   fi
   if [[ -n "$ACTIVATION_ARTIFACTS" ]]; then
-    echo "activation-artifacts: $ACTIVATION_ARTIFACTS"
+    echo "activation-artifacts: \"$ACTIVATION_ARTIFACTS\""
   fi
   if [[ -n "$RISK_LEVEL" ]]; then
     echo "risk-level: $RISK_LEVEL"

scripts/validate-skills.sh

@@ -39,44 +39,44 @@ validate_csv_values() {
   fi
 }
 
-validate_capabilities() {
+validate_csv_field() {
   local file="$1"
-  local value="$2"
-  local capability
+  local field="$2"
+  local value="$3"
+  local item_validator="${4:-}"
 
-  validate_csv_values "$file" "capabilities" "$value"
+  validate_csv_values "$file" "$field" "$value"
 
-  IFS=',' read -r -a items <<< "$value"
-  for capability in "${items[@]}"; do
-    capability="$(trim "$capability")"
-    [[ -z "$capability" ]] && continue
-    if [[ ! "$capability" =~ ^[a-z0-9]+([.-][a-z0-9]+)*$ ]]; then
-      echo "FAIL $file: invalid capability '$capability'"
-      FAILED=1
-    fi
-  done
+  if [[ -n "$item_validator" ]]; then
+    IFS=',' read -r -a items <<< "$value"
+    for item in "${items[@]}"; do
+      item="$(trim "$item")"
+      [[ -z "$item" ]] && continue
+      "$item_validator" "$file" "$item"
+    done
+  fi
 }
 
-validate_activation_events() {
+validate_capability_item() {
   local file="$1"
-  local value="$2"
-  local event
-
-  validate_csv_values "$file" "activation-events" "$value"
+  local capability="$2"
+  if [[ ! "$capability" =~ ^[a-z0-9]+([.-][a-z0-9]+)*$ ]]; then
+    echo "FAIL $file: invalid capability '$capability'"
+    FAILED=1
+  fi
+}
 
-  IFS=',' read -r -a items <<< "$value"
-  for event in "${items[@]}"; do
-    event="$(trim "$event")"
-    [[ -z "$event" ]] && continue
-    case "$event" in
-      user-prompt|session-start|pre-tool-use|post-tool-use|pre-compact|session-end)
-        ;;
-      *)
-        echo "FAIL $file: unsupported activation event '$event'"
-        FAILED=1
-        ;;
-    esac
-  done
+validate_activation_event_item() {
+  local file="$1"
+  local event="$2"
+  case "$event" in
+    user-prompt|session-start|pre-tool-use|post-tool-use|pre-compact|session-end)
+      ;;
+    *)
+      echo "FAIL $file: unsupported activation event '$event'"
+      FAILED=1
+      ;;
+  esac
 }
 
 if [[ ! -d "$ROOT" ]]; then
@@ -149,15 +149,15 @@ for file in "$ROOT"/*/SKILL.md; do
 
   if [[ "$metadata_version" == "2" ]]; then
     if [[ -n "$capabilities" ]]; then
-      validate_capabilities "$file" "$capabilities"
+      validate_csv_field "$file" "capabilities" "$capabilities" validate_capability_item
     fi
 
     if [[ -n "$activation_intents" ]]; then
       validate_csv_values "$file" "activation-intents" "$activation_intents"
     fi
 
     if [[ -n "$activation_events" ]]; then
-      validate_activation_events "$file" "$activation_events"
+      validate_csv_field "$file" "activation-events" "$activation_events" validate_activation_event_item
     fi
 
     if [[ -n "$activation_artifacts" ]]; then