Skip to content

Commit 145fe4d

Browse files
authored
Merge pull request #24 from alecpl/dev/issuer-fix
Use the same issuer in token and discovery responses
2 parents 67877fe + 869ca84 commit 145fe4d

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

src/IdTokenResponse.php

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,17 +55,10 @@ protected function getBuilder(
5555
($this->useMicroseconds ? microtime(true) : time())
5656
);
5757

58-
if ($this->currentRequestService) {
59-
$uri = $this->currentRequestService->getRequest()->getUri();
60-
$issuer = $uri->getScheme() . '://' . $uri->getHost() . ($uri->getPort() ? ':' . $uri->getPort() : '');
61-
} else {
62-
$issuer = 'https://' . $_SERVER['HTTP_HOST'];
63-
}
64-
6558
return $this->config
6659
->builder()
6760
->permittedFor($accessToken->getClient()->getIdentifier())
68-
->issuedBy($issuer)
61+
->issuedBy('https://' . $_SERVER['HTTP_HOST'])
6962
->issuedAt($dateTimeImmutableObject)
7063
->expiresAt($dateTimeImmutableObject->add(new DateInterval('PT1H')))
7164
->relatedTo($userEntity->getIdentifier());

src/Laravel/DiscoveryController.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
use Illuminate\Http\Request;
66
use Illuminate\Support\Facades\Route;
7+
use Illuminate\Support\Facades\URL;
78
use Laravel\Passport\Passport;
89

910
class DiscoveryController
@@ -13,8 +14,10 @@ class DiscoveryController
1314
*/
1415
public function __invoke(Request $request)
1516
{
17+
URL::forceScheme('https'); // for route() calls below
18+
1619
$response = [
17-
'issuer' => url('/'),
20+
'issuer' => 'https://' . $_SERVER['HTTP_HOST'],
1821
'authorization_endpoint' => route('passport.authorizations.authorize'),
1922
'token_endpoint' => route('passport.token'),
2023
'grant_types_supported' => $this->getSupportedGrantTypes(),

0 commit comments

Comments
 (0)