Skip to content

Commit 93efea6

Browse files
authored
Merge pull request #243 from jeremykendall/develop
prepare 5.5.0 release
2 parents 6e326c5 + 20f9f4a commit 93efea6

22 files changed

+1463
-221
lines changed

.github/CONTRIBUTING.md

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ We accept bug reports via issues created on [Github](https://github.com/jeremyke
1010

1111
- **Always search the issue or pull request list first** - The odds are good that if you've found a problem, someone else has found it, too.
1212

13-
- **Always try the [master branch](https://github.com/jeremykendall/php-domain-parser)** - to see if the reported bug has not already been fixed.
13+
- **Always try the [developer branch](https://github.com/jeremykendall/php-domain-parser/tree/develop)** - to see if the reported bug has not already been fixed.
1414

1515
### When submitting your report
1616

@@ -24,8 +24,18 @@ We accept bug reports via issues created on [Github](https://github.com/jeremyke
2424

2525
We accept contributions via Pull Requests on [Github](https://github.com/jeremykendall/php-domain-parser/pull).
2626

27+
- **Always make your Pull Request against the [developer branch](https://github.com/jeremykendall/php-domain-parser/tree/develop)**
28+
2729
- **[PSR-2 Coding Standard](http://www.php-fig.org/psr/psr-2/)** - Your patch won't be accepted if it doesn't pass the package coding style test suite.
2830

31+
You can resolve most of the styling code issues using the following command line:
32+
33+
```bash
34+
$ ./vendor/bin/php-cs-fixer fix -vvv --allow-risky=yes
35+
```
36+
37+
You should run this command **prior** to committing your code.
38+
2939
- **Add tests!** - Your patch won't be accepted if it doesn't have tests.
3040

3141
- **Document any change in behaviour** - Make sure the README and any other relevant documentation are kept up-to-date.

.php_cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ return PhpCsFixer\Config::create()
3333
'no_empty_comment' => true,
3434
'no_leading_import_slash' => true,
3535
'no_trailing_comma_in_singleline_array' => true,
36+
'no_trailing_whitespace' => true,
37+
'no_whitespace_in_blank_line' => true,
3638
'no_unused_imports' => true,
3739
'ordered_imports' => ['imports_order' => ['class', 'function', 'const'], 'sort_algorithm' => 'alpha'],
3840
'phpdoc_add_missing_param_annotation' => ['only_untyped' => false],

.travis.yml

Lines changed: 41 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,50 @@ language: php
22

33
sudo: false
44

5+
cache:
6+
directories:
7+
- $HOME/.composer/cache
8+
9+
env:
10+
global:
11+
- COMPOSER_ARGS="--no-interaction --prefer-source --no-suggest"
12+
513
matrix:
614
include:
715
- php: 7.0
8-
env: VALIDATE_CODING_STYLE=false RUN_PHPSTAN=false IGNORE_PLATFORMS=false
16+
env:
17+
- VALIDATE_CODING_STYLE=false
18+
- RUN_PHPSTAN=false
19+
- IGNORE_PLATFORMS=false
920
- php: 7.1
10-
env: VALIDATE_CODING_STYLE=false RUN_PHPSTAN=false IGNORE_PLATFORMS=false
21+
env:
22+
- VALIDATE_CODING_STYLE=false
23+
- RUN_PHPSTAN=false
24+
- IGNORE_PLATFORMS=false
1125
- php: 7.2
12-
env: VALIDATE_CODING_STYLE=true RUN_PHPSTAN=true IGNORE_PLATFORMS=false
26+
env:
27+
- VALIDATE_CODING_STYLE=true
28+
- RUN_PHPSTAN=true
29+
- IGNORE_PLATFORMS=false
1330
- php: 7.3
14-
env: VALIDATE_CODING_STYLE=false RUN_PHPSTAN=false IGNORE_PLATFORMS=true
31+
env:
32+
- VALIDATE_CODING_STYLE=false
33+
- RUN_PHPSTAN=false
34+
- IGNORE_PLATFORMS=true
35+
- php: 7.4snapshot
36+
env:
37+
- COLLECT_COVERAGE=false
38+
- VALIDATE_CODING_STYLE=false
39+
- RUN_PHPSTAN=false
40+
- IGNORE_PLATFORMS=true
1541
- php: nightly
16-
env: VALIDATE_CODING_STYLE=false RUN_PHPSTAN=false IGNORE_PLATFORMS=true
42+
env:
43+
- COLLECT_COVERAGE=false
44+
- IGNORE_PLATFORMS=true
45+
- RUN_PHPSTAN=true
46+
- VALIDATE_CODING_STYLE=false
1747
allow_failures:
48+
- php: 7.4snapshot
1849
- php: nightly
1950
fast_finish: true
2051

@@ -26,12 +57,13 @@ before_install:
2657
- travis_retry composer self-update
2758

2859
install:
29-
- if [ "$IGNORE_PLATFORMS" == "true" ]; then travis_retry composer update --no-interaction --prefer-source --ignore-platform-reqs; fi
30-
- if [ "$IGNORE_PLATFORMS" == "false" ]; then travis_retry composer update --no-interaction --prefer-source; fi
60+
- if [ "$IGNORE_PLATFORMS" == "true" ]; then travis_retry composer update $COMPOSER_ARGS --ignore-platform-reqs; fi
61+
- if [ "$IGNORE_PLATFORMS" == "false" ]; then travis_retry composer update $COMPOSER_ARGS; fi
3162

3263
script:
64+
- if [ "$RUN_PHPSTAN" == "true" ]; then composer phpstan; fi
65+
- if [ "$VALIDATE_CODING_STYLE" == "true" ]; then composer phpcs; fi
3366
- composer phpunit
3467

3568
after_script:
36-
- if [ "$VALIDATE_CODING_STYLE" == "true" ]; then composer phpcs; fi
37-
- if [ "$RUN_PHPSTAN" == "true" ]; then composer phpstan; fi
69+
- if [ "$COLLECT_COVERAGE" == "true" ]; then wget https://scrutinizer-ci.com/ocular.phar && php ocular.phar code-coverage:upload --format=php-clover build/clover.xml; fi

CHANGELOG.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,29 @@
22

33
All Notable changes to `PHP Domain Parser` **5.x** series will be documented in this file
44

5+
# 5.5.0 - 2019-04-14
6+
7+
### Added
8+
9+
- Support for IDNA options see [#236](https://github.com/jeremykendall/php-domain-parser/pull/236) thanks to [Insolita](https://github.com/Insolita).
10+
11+
- `PublicSuffix::labels` and `Domain::labels` to return the VO labels see [#241](https://github.com/jeremykendall/php-domain-parser/pull/241)
12+
13+
- `IDNAConverterTrait::parse` (internal)
14+
15+
### Fixed
16+
17+
- Don't swallow cache errors [#232](https://github.com/jeremykendall/php-domain-parser/issues/232)
18+
- Update travis settings to allow testing against future version of PHP.
19+
20+
### Deprecated
21+
22+
- `IDNAConverterTrait::setLabels` replaced by `IDNAConverterTrait::parse` (internal)
23+
24+
### Removed
25+
26+
- None
27+
528
# 5.4.0 - 2018-11-22
629

730
### Added

0 commit comments

Comments
 (0)