Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit ef487a6

Browse files
committedMay 23, 2020
hardening
1 parent 3e03249 commit ef487a6

File tree

2 files changed

+18
-14
lines changed

2 files changed

+18
-14
lines changed
 

‎app/Http/Controllers/Auth/RegisterController.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ protected function validator(array $data)
6767
return Validator::make(
6868
$data,
6969
[
70-
'name' => 'required|max:255|unique:users',
71-
'first_name' => '',
72-
'last_name' => '',
70+
'name' => 'required|max:255|unique:users|alpha_dash',
71+
'first_name' => 'alpha_dash',
72+
'last_name' => 'alpha_dash',
7373
'email' => 'required|email|max:255|unique:users',
7474
'password' => 'required|min:6|max:30|confirmed',
7575
'password_confirmation' => 'required|same:password',
@@ -112,9 +112,9 @@ protected function create(array $data)
112112
}
113113

114114
$user = User::create([
115-
'name' => $data['name'],
116-
'first_name' => $data['first_name'],
117-
'last_name' => $data['last_name'],
115+
'name' => strip_tags($data['name']),
116+
'first_name' => strip_tags($data['first_name']),
117+
'last_name' => strip_tags($data['last_name']),
118118
'email' => $data['email'],
119119
'password' => Hash::make($data['password']),
120120
'token' => str_random(64),

‎app/Http/Controllers/UsersManagementController.php

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@ public function store(Request $request)
6666
$validator = Validator::make(
6767
$request->all(),
6868
[
69-
'name' => 'required|max:255|unique:users',
70-
'first_name' => '',
71-
'last_name' => '',
69+
'name' => 'required|max:255|unique:users|alpha_dash',
70+
'first_name' => 'alpha_dash',
71+
'last_name' => 'alpha_dash',
7272
'email' => 'required|email|max:255|unique:users',
7373
'password' => 'required|min:6|max:20|confirmed',
7474
'password_confirmation' => 'required|same:password',
@@ -164,14 +164,18 @@ public function update(Request $request, User $user)
164164

165165
if ($emailCheck) {
166166
$validator = Validator::make($request->all(), [
167-
'name' => 'required|max:255|unique:users',
168-
'email' => 'email|max:255|unique:users',
169-
'password' => 'present|confirmed|min:6',
167+
'name' => 'required|max:255|unique:users|alpha_dash',
168+
'email' => 'email|max:255|unique:users',
169+
'first_name' => 'alpha_dash',
170+
'last_name' => 'alpha_dash',
171+
'password' => 'present|confirmed|min:6',
170172
]);
171173
} else {
172174
$validator = Validator::make($request->all(), [
173-
'name' => 'required|max:255|unique:users,name,'.$user->id,
174-
'password' => 'nullable|confirmed|min:6',
175+
'name' => 'required|max:255|alpha_dash|unique:users,name,'.$user->id,
176+
'first_name' => 'alpha_dash',
177+
'last_name' => 'alpha_dash',
178+
'password' => 'nullable|confirmed|min:6',
175179
]);
176180
}
177181

0 commit comments

Comments
 (0)
Please sign in to comment.