Switch to node-22 source

Author: jeroen

.github/workflows/build.yml

@@ -5,37 +5,40 @@ name: Building V8
 
 jobs:
   build:
-    runs-on: ubuntu-latest
-    name: ${{ matrix.distro }} / v8-${{ matrix.version }}
+    runs-on: ubuntu-24.04${{matrix.arch=='arm64' && '-arm' || ''}}
+    name: ${{ matrix.distro }} / ${{ matrix.arch }}
 
 # V8 version from node-20: https://github.com/nodejs/node/blob/v20.x-staging-backport/deps/v8/include/v8-version.h
 
     strategy:
       fail-fast: false
       matrix:
-        distro: [ 'centos-8', 'debian-11', 'debian-11-arm', 'debian-12-libcxx', 'alpine' ]
-        version: [ '11.9.169.7' ]
+        distro: [ 'alpine', 'rocky-8', 'debian-11', 'debian-12-libcxx']
+        arch: [ 'amd64', 'arm64' ]
+        exclude:
+          - distro: rocky-8
+            arch: arm64
 
     steps:
       - name: checkout
         uses: actions/checkout@v4
 
       - name: build
         run: |
-          docker build --build-arg v8_version=${{ matrix.version }} ${{ matrix.distro }} -t mybuild
+          docker build ${{ matrix.distro }} -t mybuild
 
       - name: copy
         run: |
           docker run -d --name myrun mybuild
           docker cp myrun:/v8-${{ matrix.version }}-static.tar.xz .
           docker stop myrun
-          mv v8-${{ matrix.version }}-static.tar.xz v8-${{ matrix.version }}-${{ matrix.distro }}.tar.xz
+          mv v8-${{ matrix.version }}-static.tar.xz v8-${{ matrix.version }}-${{ matrix.distro }}-${{ matrix.arch }}.tar.xz
 
       - name: store
         uses: actions/upload-artifact@v4
         with:
-          name: v8-${{ matrix.version }}-${{ matrix.distro }}
-          path: v8-${{ matrix.version }}-${{ matrix.distro }}.tar.xz
+          name: v8-${{ matrix.distro }}-${{ matrix.arch }}
+          path: v8-${{ matrix.distro }}-${{ matrix.arch }}.tar.xz
 
   release:
     runs-on: ubuntu-latest

README.md

@@ -1,15 +1,17 @@
 # Building V8
 
-Some dockerfiles for building libv8 on various platforms. Based on Jan Marvin's [v8-static](https://github.com/JanMarvin/v8-static) script for building V8 on Arch.
+Some dockerfiles for building libv8 on various platforms.
 
-Run `docker build . -t myv8` in the source dir. If all goes well, the final image has `/v8-{version}.tar.xz` in the root. Use `docker run myv8` and then `docker cp` to copy it to your system.
+The releases section in this repository has binaries as built by the GitHub actions CI.
 
-## Important notes
+## How to use
 
-Because depot_tools changes all the time, this will probably only work for recent versions of V8. To build an older V8 version, you may have to add a step to checkout an older version of depot_tools. Suitable dependency versions are storted in the [DEPS](https://github.com/v8/v8/blob/master/DEPS) file in the V8 source tree for the version you are building.
+Run `docker build . -t myv8` in any of the source dirs. If all goes well, the final image has `/v8-{version}.tar.xz` in the root. Use `docker run myv8` and then `docker cp` to copy it to your system. Also see the [CI workflow](https://github.com/jeroen/build-v8-static/blob/HEAD/.github/workflows/build.yml) how to do this.
 
-V8 pulls in a custom clang++ compiler at build time, so I think the version of g++ on your system doesn't matter. But it should still be using your system libcxx, which is what is important to use the library in your applications.
+## Some notes
+
+Nowadays we use the V8 source code bundled with nodejs, which is more portable and already includes dependencies. However if you want to build from the upstream V8 git repository instead, have a look at the [11.9-final](https://github.com/jeroen/build-v8-static/tree/11.9-final) tag for examples how to do this.
 
 This is a minimal build without internationalization which results in a single "monolith" static library. Tweak the `gn gen` command to enable other features.
 
-Building V8 requires a lot of memory, if you get random failures, docker may be running out of memory or disk space.
+Building V8 requires a lot of memory, if you get random failures, docker may be running out of memory or disk space. In this case try chaning the build command to `ninja -j1`.

alpine/55596.diff

@@ -0,0 +1,39 @@
+diff --git a/deps/v8/src/compiler/wasm-compiler.cc b/deps/v8/src/compiler/wasm-compiler.cc
+--- a/deps/v8/src/compiler/wasm-compiler.cc     2024-10-28 21:25:11.000000000 -0400
++++ b/deps/v8/src/compiler/wasm-compiler.cc     2024-11-01 02:02:22.554537121 -0400
+@@ -8613,11 +8613,13 @@
+                  '-');
+ 
+   auto compile_with_turboshaft = [&]() {
++    wasm::WrapperCompilationInfo ci;
++    ci.code_kind = CodeKind::WASM_TO_JS_FUNCTION;
++    ci.import_info.import_kind = kind;
++    ci.import_info.expected_arity = expected_arity;
++    ci.import_info.suspend = suspend;
+     return Pipeline::GenerateCodeForWasmNativeStubFromTurboshaft(
+-        env->module, sig,
+-        wasm::WrapperCompilationInfo{
+-            .code_kind = CodeKind::WASM_TO_JS_FUNCTION,
+-            .import_info = {kind, expected_arity, suspend}},
++        env->module, sig, ci,
+         func_name, WasmStubAssemblerOptions(), nullptr);
+   };
+   auto compile_with_turbofan = [&]() {
+@@ -8774,12 +8776,14 @@
+       base::VectorOf(name_buffer.get(), kMaxNameLen) + kNamePrefixLen, sig);
+ 
+   auto compile_with_turboshaft = [&]() {
++    wasm::WrapperCompilationInfo ci;
++    ci.code_kind = CodeKind::WASM_TO_JS_FUNCTION;
++    ci.import_info.import_kind = kind;
++    ci.import_info.expected_arity = expected_arity;
++    ci.import_info.suspend = suspend;
+     std::unique_ptr<turboshaft::TurboshaftCompilationJob> job =
+         Pipeline::NewWasmTurboshaftWrapperCompilationJob(
+-            isolate, sig,
+-            wasm::WrapperCompilationInfo{
+-                .code_kind = CodeKind::WASM_TO_JS_FUNCTION,
+-                .import_info = {kind, expected_arity, suspend}},
++            isolate, sig, ci,
+             nullptr, std::move(name_buffer), WasmAssemblerOptions());
+ 

alpine/Dockerfile

@@ -1,91 +1,71 @@
-# Adapted from: https://github.com/humanmade/alpine-v8
-ARG v8_version=11.9.169.7
-ARG GN_COMMIT=cc28efe62ef0c2fb32455f414a29c4a55bb7fbc4
+FROM alpine:3.16 
+
+ARG NODE_VERSION=22.18.0
+ARG BUILD_VERSION=bca39698b291b392f0b4336857caf929c603ada3
+ARG GN_VERSION=59c4bb920542ee903ee1df39097ae024e2e8226f
+
+ENV GYP_GENERATORS=ninja
+ENV pkgdir=/package
 
-# STEP 1
-# Build GN for alpine
-FROM alpine:3.16 as gn-builder
-ARG GN_COMMIT
 RUN \
-  apk add --update --virtual .gn-build-dependencies alpine-sdk binutils-gold clang curl git llvm13 ninja python3 tar xz && \
-  PATH=$PATH:/usr/lib/llvm9/bin  && \
-  cp -f /usr/bin/ld.gold /usr/bin/ld  && \
-  git clone https://gn.googlesource.com/gn /tmp/gn && \
-  git -C /tmp/gn checkout ${GN_COMMIT} && \
-  cd /tmp/gn && \
+  apk add --update git alpine-sdk binutils-gold clang curl git llvm13 ninja python3 tar xz glib-dev icu-dev libstdc++ linux-headers make &&\
+  ln -s /usr/bin/python3 /usr/bin/python
+
+RUN \
+  git clone https://gn.googlesource.com/gn && \
+  cd gn && \
+  git checkout ${GN_VERSION} && \
   python3 build/gen.py && \
   ninja -C out && \
-  cp -f /tmp/gn/out/gn /usr/local/bin/gn && \
-  apk del .gn-build-dependencies && \
-  rm -rf /tmp/* /var/tmp/* /var/cache/apk/*
+  cp out/gn /usr/local/bin/gn
 
+RUN \
+  curl -sSL https://github.com/nodejs/node/archive/refs/tags/v${NODE_VERSION}.tar.gz -o node.tar.gz && \
+  mkdir -p /v8 &&\
+  tar xf node.tar.gz -C /v8 --strip-components=3 node-22.18.0/deps/v8
 
-# STEP 2
-# Use depot_tools to fetch the V8 source and dependencies
-# This requires glibc so we use debian tools
-FROM debian:10 as source
-ARG v8_version
 RUN \
-  set -x && \
-  sed -i.bak 's@http://deb.debian.org@http://archive.debian.org@g' /etc/apt/sources.list && \
-  apt-get update && \
-  apt-get install -y git curl python3 && \
-  git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git /tmp/depot_tools && \
-  PATH=$PATH:/tmp/depot_tools && \
-  cd /tmp && \
-  fetch --nohooks v8 && \
-  cd /tmp/v8 && \
-  gclient sync --nohooks -D --force --reset && \
-  gclient sync --revision ${v8_version} && \
-  apt-get remove --purge -y git curl python3 && \
-  apt-get autoremove -y && \
-  rm -rf /var/lib/apt/lists/*
+  git clone https://chromium.googlesource.com/chromium/src/build.git /build &&\
+  git -C /build checkout ${BUILD_VERSION} &&\
+  rm -Rf /v8/build &&\
+  ln -sf /build /v8/build
 
+RUN \
+  echo "checkout_google_benchmark = false" > /v8/build/config/gclient_args.gni
 
-# STEP 3
-# Build V8 for alpine
-FROM alpine:3.16 as v8
-COPY --from=source /tmp/v8 /tmp/v8
-COPY --from=gn-builder /usr/local/bin/gn /tmp/v8/buildtools/linux64/gn
 RUN \
-  apk add --update --virtual .v8-build-dependencies curl g++ gcc glib-dev icu-dev libstdc++ linux-headers make ninja python3 tar xz && \
-  ln -s /usr/bin/python3 /usr/bin/python && \
-  cd /tmp/v8 && \
-  ./tools/dev/v8gen.py x64.release -- \
-    binutils_path=\"/usr/bin\" \
-    target_os=\"linux\" \
-    target_cpu=\"x64\" \
-    v8_target_cpu=\"x64\" \
-    v8_enable_future=true \
-    is_official_build=false \
-    is_cfi=false \
-    is_clang=false \
-    is_debug=false \
-    use_custom_libcxx=false \
-    use_sysroot=false \
-    use_gold=false \
-    use_allocator_shim=false \
-    treat_warnings_as_errors=false \
-    symbol_level=0 \
-    strip_debug_info=true \
-    v8_monolithic=true \
-    v8_use_external_startup_data=false \
-    v8_enable_i18n_support=false \
-    v8_enable_gdbjit=false \
-    v8_static_library=true \
-    v8_experimental_extra_library_files=[] \
-    v8_extra_library_files=[] && \
-  ninja -C out.gn/x64.release -j $(getconf _NPROCESSORS_ONLN) "v8_monolith" "d8" && \
-  find /tmp/v8/out.gn/x64.release -name '*.a'
+  cd /usr/bin &&\
+  ln -s g++ $(uname -m)-linux-gnu-g++ &&\
+  ln -s gcc $(uname -m)-linux-gnu-gcc &&\
+  ln -s ar $(uname -m)-linux-gnu-ar
+
+# Patch from https://github.com/nodejs/node/issues/55596
+COPY 55596.diff /tmp/55596.diff
+RUN patch -p2 -i /tmp/55596.diff
+
+RUN cd /v8 &&\
+  gn gen v8.static -vv --fail-on-unused-args \
+    --args='v8_monolithic=true \
+            v8_static_library=true \
+            v8_enable_sandbox=false \
+            is_clang=false \
+            is_asan=false \
+            use_gold=false \
+            is_debug=false \
+            is_official_build=false \
+            treat_warnings_as_errors=false \
+            clang_use_chrome_plugins=false \
+            v8_enable_i18n_support=false \
+            v8_use_external_startup_data=false \
+            use_custom_libcxx=false \
+            use_sysroot=false'
+
+RUN cd /v8 && ninja -C v8.static -j2 "v8_monolith" "d8"
 
-# STEP 4
-# Create package archive
-ARG v8_version
-ENV pkgdir /package
-RUN cd /tmp/v8 && \
+RUN cd /v8 &&\
   install -d ${pkgdir}v8 && \
   install -d ${pkgdir}/v8/lib && \
-  install -Dm755 out.gn/x64.release/obj/libv8_monolith.a ${pkgdir}/v8/lib/libv8_monolith.a && \
+  install -Dm755 v8.static/obj/libv8_monolith.a ${pkgdir}/v8/lib/libv8_monolith.a && \
   install -d ${pkgdir}/v8/include && \
   install -Dm644 include/*.h ${pkgdir}/v8/include && \
   install -d ${pkgdir}/v8/include/cppgc && \