Skip to content

Commit c216e1b

Browse files
committed
Use String type
1 parent 2ad14a0 commit c216e1b

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

rocky-8/4bd36a1ac2f.diff

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,21 @@ index f608d678505e..882be746310d 100644
66
}
77

88
void reportCallWithArgument(ConsoleAPIType type, const String16& message) {
9-
- std::vector<v8::Local<v8::Value>> arguments(1,
10-
- toV8String(m_isolate, message));
9+
- auto arguments =
10+
- v8::to_array<v8::Local<v8::Value>>({toV8String(m_isolate, message)});
1111
+ auto arguments =
12-
+ v8::to_array<v8::Local<v8::Value>>({toV8String(m_isolate, message)});
12+
+ v8::to_array<v8::Local<v8::String>>({toV8String(m_isolate, message)});
1313
reportCall(type, arguments);
1414
}
1515

1616
@@ -116,8 +116,8 @@ class ConsoleHelper {
1717
id)) {
1818
return;
1919
}
20-
- std::vector<v8::Local<v8::Value>> arguments(1,
21-
- toV8String(m_isolate, message));
20+
- auto arguments =
21+
- v8::to_array<v8::Local<v8::Value>>({toV8String(m_isolate, message)});
2222
+ auto arguments =
23-
+ v8::to_array<v8::Local<v8::Value>>({toV8String(m_isolate, message)});
23+
+ v8::to_array<v8::Local<v8::String>>({toV8String(m_isolate, message)});
2424
reportCall(ConsoleAPIType::kWarning, arguments);
2525
}
2626

rocky-8/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ RUN patch -p0 -i /tmp/gcc-8.diff
3939

4040
# Revert https://github.com/v8/v8/commit/4bd36a1ac2f
4141
COPY 4bd36a1ac2f.diff /tmp/4bd36a1ac2f.diff
42-
RUN patch -d /v8 -Rp1 -i /tmp/4bd36a1ac2f.diff
42+
RUN patch -d /v8 -p1 -i /tmp/4bd36a1ac2f.diff
4343

4444
RUN \
4545
echo "checkout_google_benchmark = false" > /v8/build/config/gclient_args.gni

0 commit comments

Comments
 (0)