Skip to content

Commit c76237c

Browse files
committed
Final tweaks
1 parent 92e3d15 commit c76237c

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ jobs:
3737
- name: store
3838
uses: actions/upload-artifact@v4
3939
with:
40-
name: v8-${{ matrix.version }}-${{ matrix.distro }}-${{ matrix.arch }}
41-
path: v8-${{ matrix.version }}-${{ matrix.distro }}-${{ matrix.arch }}.tar.xz
40+
name: v8-${{ matrix.distro }}-${{ matrix.arch }}
41+
path: v8-${{ matrix.distro }}-${{ matrix.arch }}.tar.xz
4242

4343
release:
4444
runs-on: ubuntu-latest

README.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,17 @@
11
# Building V8
22

3-
Some dockerfiles for building libv8 on various platforms. Based on Jan Marvin's [v8-static](https://github.com/JanMarvin/v8-static) script for building V8 on Arch.
3+
Some dockerfiles for building libv8 on various platforms.
44

5-
Run `docker build . -t myv8` in the source dir. If all goes well, the final image has `/v8-{version}.tar.xz` in the root. Use `docker run myv8` and then `docker cp` to copy it to your system.
5+
The releases section in this repository has binaries as built by the GitHub actions CI.
66

7-
## Important notes
7+
## How to use
88

9-
Because depot_tools changes all the time, this will probably only work for recent versions of V8. To build an older V8 version, you may have to add a step to checkout an older version of depot_tools. Suitable dependency versions are storted in the [DEPS](https://github.com/v8/v8/blob/master/DEPS) file in the V8 source tree for the version you are building.
9+
Run `docker build . -t myv8` in any of the source dirs. If all goes well, the final image has `/v8-{version}.tar.xz` in the root. Use `docker run myv8` and then `docker cp` to copy it to your system. Also see the [CI workflow](https://github.com/jeroen/build-v8-static/blob/HEAD/.github/workflows/build.yml) how to do this.
1010

11-
V8 pulls in a custom clang++ compiler at build time, so I think the version of g++ on your system doesn't matter. But it should still be using your system libcxx, which is what is important to use the library in your applications.
11+
## Some notes
12+
13+
Nowadays we use the V8 source code bundled with nodejs, which is more portable and already includes dependencies. However if you want to build from the upstream V8 git repository instead, have a look at the [11.9-final](https://github.com/jeroen/build-v8-static/tree/11.9-final) tag for examples how to do this.
1214

1315
This is a minimal build without internationalization which results in a single "monolith" static library. Tweak the `gn gen` command to enable other features.
1416

15-
Building V8 requires a lot of memory, if you get random failures, docker may be running out of memory or disk space.
17+
Building V8 requires a lot of memory, if you get random failures, docker may be running out of memory or disk space. In this case try chaning the build command to `ninja -j1`.

0 commit comments

Comments
 (0)