Skip to content

Commit cff4a7b

Browse files
committed
fix(theme): tokyo-night-storm unread brighter than waiting on dark bg
The unread row color #7dcfff (cyan) had a higher Rec. 601 luminance (188.0) than waiting #e0af68 (181.6), so an unread Idle row visually outshone a Waiting peer on the dark-themed sort, contradicting the Attention-sort promoter contract from agent-of-empires#2088 that floats unread rows just below Waiting. Cyan is also off the upstream spec slot for info: tokyonight.nvim defines colors.info = colors.blue2 = #0db9d7 directly. Switch to blue2 #0db9d7 (Rec. 601 = 137.0). The replacement sits between waiting (181.6) and idle (97.1) on dark bg, restores the ordering under both Rec. 601 and WCAG 2.1 relative luminance, matches the upstream info slot, and stays inside the Storm palette. Extend theme_attention_hierarchy_holds to also assert waiting > unread > idle for every builtin theme so future drift is caught at test time. The new assertion fails on the prior #7dcfff with the exact panic 'tokyo-night-storm (dark bg): waiting luminance 181.6 should exceed unread 188.0'. unread vs fresh_idle ordering is intentionally unconstrained so themes can tie them (empire and zinc do, at the same Tailwind step).
1 parent a561584 commit cff4a7b

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

src/tui/styles/themes.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -537,10 +537,16 @@ mod tests {
537537
let w = luminance(theme.waiting);
538538
let f = luminance(theme.fresh_idle);
539539
let i = luminance(theme.idle);
540+
let u = luminance(theme.unread);
540541
// Waiting beats fresh-idle.
541542
cmp("waiting", w, "fresh_idle", f);
542543
// Fresh-idle beats fully-decayed idle.
543544
cmp("fresh_idle", f, "idle", i);
545+
// Unread sits between waiting and idle (Attention sort
546+
// promoter from #2088). Its relationship to fresh_idle is
547+
// intentionally unconstrained: themes may tie them.
548+
cmp("waiting", w, "unread", u);
549+
cmp("unread", u, "idle", i);
544550
}
545551
}
546552
}

themes/builtin/tokyo-night-storm.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ running = "#9ece6a"
1313
waiting = "#e0af68"
1414
fresh_idle = "#ff9e64"
1515
idle = "#565f89"
16-
unread = "#7dcfff"
16+
unread = "#0db9d7"
1717
error = "#f7768e"
1818
terminal_active = "#7aa2f7"
1919
group = "#7dcfff"

0 commit comments

Comments
 (0)