Crashing after about 30 seconds in docker image.

[jonasbp2011]

Type: Bug Report

• Try to follow the update procedure described in the README and try again before opening this issue.

Your Environment

• Version used:
  • Version (stable release): Flood 4.3.1
  • Commit ID (development release) git --no-pager log -1
• Environment name and version:
  • Node.js version node --version
  • npm version npm --version
  • Web browser name and version
• Operating system and version: Docker host: Ubuntu 20.04.1
• Torrent client and version:

Summary

I created a docker container with Flood and rTorrent together, as per the instructions on #120, and then started it with the following docker command:

docker run -it \
-e HOME=/config \
-v /mnt/data/configs/rtorrent-flood/config:/config \
-v /mnt/data:/data \
-u 1000:1000 \
-p 3000:3000 \
-p 0.0.0.0:6881:6881 \
rtorrent-flood \
--port 3000 \
--allowedpath /data

The docker manages to start up successfully, however, after about 30 seconds it comes to a grinding halt, with the following error:

Log

�[32mFlood server starting on �[4mhttp://0.0.0.0:3000�[24m.�[39m
�[32m�[39m
�[0mGET /overview �[32m200�[0m 3.372 ms - 604�[0m
�[0mGET /static/css/main.56ee28f23fc32a5f8409.css �[36m304�[0m 1.782 ms - -�[0m
�[0mGET /static/js/main.9463b2e2.js �[36m304�[0m 0.420 ms - -�[0m
�[0mGET /static/css/648.508b6bc040707a7791ff.css �[36m304�[0m 0.902 ms - -�[0m
�[0mGET /static/js/648.c6db9df3.chunk.js �[36m304�[0m 0.767 ms - -�[0m
�[0mGET /static/js/671.20b7509a.chunk.js �[36m304�[0m 0.317 ms - -�[0m
�[0mGET /api/auth/verify?1608498042164 �[32m200�[0m 3.368 ms - 109�[0m
�[0mGET /api/settings �[32m200�[0m 3.124 ms - 2�[0m
�[0mGET /api/client/settings �[32m200�[0m 5.048 ms - 615�[0m
�[0mGET /static/js/842.d2fc6b7e.chunk.js �[36m304�[0m 1.063 ms - -�[0m
�[0mGET /static/js/379.a66ec499.chunk.js �[36m304�[0m 1.019 ms - -�[0m
�[0mGET /static/js/flag2.5ef334b4.chunk.js �[36m304�[0m 1.135 ms - -�[0m
�[0mGET /static/media/Roboto-regular.11bce66a.woff2 �[36m304�[0m 0.979 ms - -�[0m
�[0mGET /static/media/Roboto-italic.766b7c5c.woff2 �[36m304�[0m 0.820 ms - -�[0m
�[0mGET /static/media/Roboto-500.c7e17507.woff2 �[36m304�[0m 0.681 ms - -�[0m
�[0mGET /static/media/Roboto-700.2b8c7cb1.woff2 �[36m304�[0m 0.324 ms - -�[0m
�[0mGET /favicon.ico �[32m200�[0m 1.784 ms - -�[0m
�[0mGET /api/notifications?limit=10&start=0 �[32m200�[0m 1.489 ms - 60�[0m
Killing rTorrent daemon...
/usr/local/lib/node_modules/flood/dist/index.js:2
....... [Long line here] .........
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            

TypeError: Cannot read property 'length' of undefined
    at /usr/local/lib/node_modules/�[4mflood�[24m/dist/index.js:2:1269542
    at Array.filter (<anonymous>)
    at /usr/local/lib/node_modules/�[4mflood�[24m/dist/index.js:2:1269523

I can supply the full log if required, but it was too long to post here or in any pastebin-like service.

Expected Behavior

The container shouldn't crash shortly after starting up.

Current Behavior

Crashes at launch.

Possible Solution

I don't know if this is related to issues with write permissions to the volume being mounted, since I had to connect to rTorrent through scgi on port 3001 instead of the socket file, due to permission issues.
The said permissions error is: rtorrent: Error in option file: ~/.rtorrent.rc:98: Could not prepare socket for listening: Operation not permitted

Steps to Reproduce

1. Set up combined docker container as per Run Flood (and torrent clients) in containers #120 (reply in thread)
2. Place the given .rtorrent.rc file in the config directory.
3. Replace

execute.nothrow = chmod,770,(cat,(cfg.basedir),rtorrent.sock)```
with
`network.scgi.open_port = 127.0.0.1:3001`
4. Log in to the Flood web interface, and the crash should occur within 30 seconds.

## Context

<!--- (Optional) What are you trying to accomplish? -->

[jesec]

Per your configuration, make sure that /mnt/data/configs/rtorrent-flood/config is existent and owned by 1000:1000.

Additionally, there is an unreleased change that fixed certain issues with disk usage function. Try jesec/rtorrent-flood image which uses cutting edge revision.

BTW: For security reasons, it is discouraged to place config directory to a path permitted by —allowedpath. Attackers, if they somehow gain access to Flood, may be able to override databases and configurations of rTorrent/Flood, which may lead to undesired consequences.

[jonasbp2011]

Alright, so I managed to get it working, however with a workaround rather than actually getting it to work.
The entire SMB share located at /mnt/data is owned by 1000:1000, and accessed as that user on the VM where I am running Portainer. I managed to workaround the socket issue by mounting a volume, for the socket only, directly from the VM instead of from the SMB share, which somehow worked, despite also being owned by user 1000:1000.

The image provided fixed the issue with crashing I was having, thanks for that.

I also changed some stuff with the mounting of the SMB share (creating new shares specifically for this purpose), such that I avoided having the config directory in the path permitted by -allowedpath.

As such, the final docker command looks like this, in case any others stumble upon the same issue as I:

docker run -d \
--name rtorrent-flood \
-e HOME=/config \
-v /mnt/rtorrent-flood-config:/config \
-v /mnt/rtorrent-flood-data:/data \
-v /home/portainer/rtorrent-flood-config:/socket \
-u 1002:1002 \
-p 3000:3000 \
-p 0.0.0.0:6881:6881 \
jesec/rtorrent-flood \
--port 3000 \
--allowedpath /data

(The folder /home/portainer/rtorrent-flood-config is actually owned by user 1002, despite being located in portainer's home folder)

I am successfully able to read and write .torrent files and downloads in the data volume, and save configurations in the config volume, but for some reason the socket still doesn't like to be located inside the config volume, citing the same Operation not permitted error as before.

[jesec]

Alright, so I managed to get it working, however with a workaround rather than actually getting it to work.
The entire SMB share located at /mnt/data is owned by 1000:1000, and accessed as that user on the VM where I am running Portainer. I managed to workaround the socket issue by mounting a volume, for the socket only, directly from the VM instead of from the SMB share, which somehow worked, despite also being owned by user 1000:1000.

The image provided fixed the issue with crashing I was having, thanks for that.

I also changed some stuff with the mounting of the SMB share (creating new shares specifically for this purpose), such that I avoided having the config directory in the path permitted by -allowedpath.

As such, the final docker command looks like this, in case any others stumble upon the same issue as I:

docker run -d \
--name rtorrent-flood \
-e HOME=/config \
-v /mnt/rtorrent-flood-config:/config \
-v /mnt/rtorrent-flood-data:/data \
-v /home/portainer/rtorrent-flood-config:/socket \
-u 1002:1002 \
-p 3000:3000 \
-p 0.0.0.0:6881:6881 \
jesec/rtorrent-flood \
--port 3000 \
--allowedpath /data

(The folder /home/portainer/rtorrent-flood-config is actually owned by user 1002, despite being located in portainer's home folder)

I am successfully able to read and write .torrent files and downloads in the data volume, and save configurations in the config volume, but for some reason the socket still doesn't like to be located inside the config volume, citing the same Operation not permitted error as before.

Unix sockets need to be in local Unix mounts. It might not work properly with network drives. It is generally not a good idea to use shared network drives due to the decreased performance, potential connectivity issues and other caveats. BitTorrent operations are IO intensive and requires stable underlying devices. You should deploy rTorrent and Flood on the machine that has the physical drive.